From: Leo Liu <sdl.web@gmail.com>
To: "Rüdiger Sonderfeld" <ruediger@c-plusplus.de>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>,
"emacs-devel@gnu.org" <emacs-devel@gnu.org>
Subject: Re: [PATCH 3/3] octave.el: Go to error in inferior-octave.
Date: Fri, 04 Oct 2013 18:04:36 +0800 [thread overview]
Message-ID: <m1mwmp8i8b.fsf@gmail.com> (raw)
In-Reply-To: <2832315.j8Ubslmhy0@descartes> ("Rüdiger Sonderfeld"'s message of "Thu, 03 Oct 2013 15:39:14 +0200")
I have committed the patch to use `compilation-shell-minor-mode' please
give it a try. Thanks.
On 2013-10-03 21:39 +0800, Rüdiger Sonderfeld wrote:
> Oh, I was looking for something like `compilation-shell-minor-mode' yesterday
> but must have missed it. This should probably make patches 1 and 3 obsolete.
> But I think patch 2 is still valid. Comint is already having highlight for
> the prompt and adding our own highlight in octave.el is not necessary and just
> confusing.
The small prompt font-lock by inferior-octave shouldn't be a problem
because it will have effect only on prompts of past inputs. BTW, seems
stop working that way in trunk.
Leo
prev parent reply other threads:[~2013-10-04 10:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-02 20:39 [PATCH 3/3] octave.el: Go to error in inferior-octave Rüdiger Sonderfeld
2013-10-03 3:57 ` Stefan Monnier
2013-10-03 4:07 ` Leo Liu
2013-10-03 13:39 ` Rüdiger Sonderfeld
2013-10-04 10:04 ` Leo Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1mwmp8i8b.fsf@gmail.com \
--to=sdl.web@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=ruediger@c-plusplus.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).