From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Leo Liu Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 5811404: Replace eldoc-documentation-function with a hook Date: Thu, 14 Jul 2016 21:36:23 +0800 Message-ID: References: <20160707032857.31916.95107@vcs.savannah.gnu.org> <20160707032857.E4A1422015C@vcs.savannah.gnu.org> <20160707235954.GA6381@holos.localdomain> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1468505798 9235 80.91.229.3 (14 Jul 2016 14:16:38 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 14 Jul 2016 14:16:38 +0000 (UTC) Cc: Mark Oteiza , Stefan Monnier , emacs-devel@gnu.org To: John Wiegley Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jul 14 16:16:33 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bNhRB-0006MP-Ov for ged-emacs-devel@m.gmane.org; Thu, 14 Jul 2016 16:16:25 +0200 Original-Received: from localhost ([::1]:54204 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNhRB-0000xB-3J for ged-emacs-devel@m.gmane.org; Thu, 14 Jul 2016 10:16:25 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54179) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNgoi-0008C6-VZ for emacs-devel@gnu.org; Thu, 14 Jul 2016 09:36:41 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bNgof-0000Ap-O8 for emacs-devel@gnu.org; Thu, 14 Jul 2016 09:36:40 -0400 Original-Received: from mail-wm0-x241.google.com ([2a00:1450:400c:c09::241]:32849) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNgof-0000Ah-Ga for emacs-devel@gnu.org; Thu, 14 Jul 2016 09:36:37 -0400 Original-Received: by mail-wm0-x241.google.com with SMTP id o80so9246569wme.0 for ; Thu, 14 Jul 2016 06:36:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:face:date:in-reply-to:message-id :user-agent:mime-version; bh=MKDxpWyVWFMQx3Y5VTXClosAcYAdGammkUW0JGAYpAc=; b=UKjNVp/u8pzHV7Y2MhPGHYfz+UyPJZkerj2mOqe72nlfTO7jTp1zZEayEYSWBmvQOR UV7mzkIIQERb1GWyUU70+fkwMjAjYpEHm/o2ctD5DKgQooddUa9yWfX2i8TViouPrGe1 cls9Z8VqGxHPrUxd+3dLyfCEN94gQ9x/XYYrVLU99uOkKF5LKtzRpeV9Kcs8m3ESYklC DSLqWvbZ0A1M8EzD4PTpJxtOtdeKzFChwAwYMdzYOwnEXIwkG9iFbR684q449nn80iU0 sbrOezCuenoBkkd5trnz5UL4mGmYqhtC28VTZVA5Noe03ZZdWadrZfCswSR0VSLyn+T5 z8Rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:face:date :in-reply-to:message-id:user-agent:mime-version; bh=MKDxpWyVWFMQx3Y5VTXClosAcYAdGammkUW0JGAYpAc=; b=JZ7NIoXaGGiFQAJ38Z2BgNiXEkQredxNCbqYoy8e9mJIfciVBApV23LhaPK/umR2pn ChL6cCzCeN5IZR71HeMafsUP8lSk5y9U1lZivYdIN4UQE0+LnwRtdqIT9HBzh37LYT33 Eh5Mx2+f0/ZoYIcENLv5XyFZVQnz86qEit0xc0ZnQ3hYQwIEXkKy69qVnVatve2WN5/M VvqktwBvK6niML8Anei3MK3waS3yss7gxNJX15fOZnJaQleGMV5kxxvQSvXYKRfU7qxJ vEuBMwSZUMRYl4Q2vRwYh6dazk/ax+uBlweuZxFgLNi5XmlOGQdINiiBRxqz3IjmkDfF 2cZw== X-Gm-Message-State: ALyK8tIa267wH/cSUnw4odyodWcPGzKacgRzmEc/41RVvuRRCbIOxPE16rEHQ6O/D0eTvQ== X-Received: by 10.28.4.194 with SMTP id 185mr33064254wme.91.1468503396394; Thu, 14 Jul 2016 06:36:36 -0700 (PDT) Original-Received: from zeuss-MacBook-Pro.local ([46.101.90.246]) by smtp.gmail.com with ESMTPSA id x62sm6676836wmf.13.2016.07.14.06.36.30 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 14 Jul 2016 06:36:34 -0700 (PDT) Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoAgMAAADxkFD+AAAADFBMVEUvT09qWs3/pQD///+J kUVcAAAAAWJLR0QAiAUdSAAAAAlwSFlzAAALEwAACxMBAJqcGAAAAAd0SU1FB9cBBwMLOd3veKQA AACuSURBVBjTldE9CgIxEAXgB+lEyFUC2wo5ikdZ8DSypxhMY7H9VuIVwlqkGRgnm59VsHGafIQ3 CZlAtmKIRaHETgYa12lqvEsPYKf8wXHsPGfqPaUM0g9aJPKFXkmNQmSDqwzz4Fpgpz+6WAPY2z5o uPJJpu0uypcl4nyCibMLQ8lCiVjayLoQvw5LsVKQuHPRR958HZbOcVsKeepcLxpByjycGvnKmY+c MBvrtyjfe0vmuLvdq/kAAAAASUVORK5CYII= In-Reply-To: (Stefan Monnier's message of "Sat, 09 Jul 2016 20:27:52 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.95 (OS X 10.11.5) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:400c:c09::241 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:205675 Archived-At: On 2016-07-09 20:27 -0400, Stefan Monnier wrote: > A *-function variable is not an advice, but a hook. > > It's a different kind of hook than those manipulated by add-hook (which > have names ending in -hook or -functions), but it's still a hook and > those have been used for many years in various parts of Emacs. > > It just so happens that the operations that can manipulate those hooks > conveniently (add-function/remove-function) are provided in the same > file as the new advice-add, but that's only because it was convenient > and natural to implement advice-add on top of those new operations. May we have this incompatible change reverted? Thanks, Leo