unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Daniel Martín" <mardani29@yahoo.es>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
Subject: Re: [PATCH] Fix some failing tests in BSD systems
Date: Wed, 06 Jan 2021 10:41:57 +0100	[thread overview]
Message-ID: <m1mtxmh062.fsf@yahoo.es> (raw)
In-Reply-To: <a9fd5602-d08c-471d-6fa6-c027d3739d1e@yandex.ru> (Dmitry Gutov's message of "Wed, 6 Jan 2021 03:38:04 +0200")

Dmitry Gutov <dgutov@yandex.ru> writes:

>
> In the meantime, plot thickens: as pointed out privately by Davis
> Herring, using 'find' on a directory without a trailing slash will
> fail if the directory is a symlink (it will only list the symlink
> itself).
>
> At this point we could double down on this approach and use the '-H'
> argument (though grep-find-template doesn't make this easy), or return 
> to your original patch. Or yet alternatively, paper over this inside
> the xref-location-group defmethod. The two alternatives attached.
>
> So I guess I should ask: was the particular behavior annoying by
> itself, or is it only a problem because of the failing test?
>
> I also wonder whether all macOS users see this, or whether it's maybe
> fixed in some latest version of BSD find. Because it's apparently 
> (arguably) a bug: https://unix.stackexchange.com/a/320440/166215

I think the safest and simplest route is to just "fix" the tests so they
pass in all systems.  We shouldn't risk introducing regressions just to
work around what POSIX says could be a 'find' bug in some BSD systems
(and maybe only Apple systems, I don't have any other BSD system to test
with).

It only causes a slight cosmetic problem, which should be fixed whenever
they fix the bug, without needing any code change from our side.



  reply	other threads:[~2021-01-06  9:41 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <m1sg7i7xfl.fsf.ref@yahoo.es>
2021-01-03 17:16 ` [PATCH] Fix some failing tests in BSD systems Daniel Martín
2021-01-03 17:35   ` Eli Zaretskii
2021-01-03 21:08     ` Daniel Martín
2021-01-04  1:41     ` Dmitry Gutov
2021-01-04  3:30       ` Eli Zaretskii
2021-01-04 13:10         ` Dmitry Gutov
2021-01-04 15:52           ` Eli Zaretskii
2021-01-04 17:10             ` Dmitry Gutov
2021-01-04 22:25               ` Daniel Martín
2021-01-06  1:38                 ` Dmitry Gutov
2021-01-06  9:41                   ` Daniel Martín [this message]
2021-01-06 17:17                     ` Dmitry Gutov
2021-01-06 18:48                       ` Stefan Monnier
2021-01-06 21:17                         ` Dmitry Gutov
2021-01-04  1:43   ` Dmitry Gutov
2021-01-04  3:48     ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m1mtxmh062.fsf@yahoo.es \
    --to=mardani29@yahoo.es \
    --cc=dgutov@yandex.ru \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).