* File lisp/abbrevlist.el
@ 2011-03-23 1:15 Leo
2011-03-23 8:31 ` Andreas Röhler
2011-03-23 17:46 ` Stefan Monnier
0 siblings, 2 replies; 12+ messages in thread
From: Leo @ 2011-03-23 1:15 UTC (permalink / raw
To: emacs-devel
I suggest obsolete/remove file lisp/abbrevlist.el since it contains a
single broken function that nobody seems to use.
Leo
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: File lisp/abbrevlist.el
2011-03-23 1:15 File lisp/abbrevlist.el Leo
@ 2011-03-23 8:31 ` Andreas Röhler
2011-03-23 9:55 ` Leo
2011-03-24 1:39 ` Richard Stallman
2011-03-23 17:46 ` Stefan Monnier
1 sibling, 2 replies; 12+ messages in thread
From: Andreas Röhler @ 2011-03-23 8:31 UTC (permalink / raw
To: Leo; +Cc: Emacs developers
Am 23.03.2011 02:15, schrieb Leo:
> I suggest obsolete/remove file lisp/abbrevlist.el since it contains a
> single broken function that nobody seems to use.
>
> Leo
>
>
>
Hi Leo,
would consider it a potentially useful function though.
Maybe put it into abbrev.el?
BTW what I missed is a way to get the right abbrev table when editing.
Solved that here locally meanwhile and may provide the code.
For example in Emacs-lisp-mode would expext
emacs-lisp-mode-abbrev-table
while the right one to edit is called
lisp-mode-abbrev-table
emacs-lisp-mode-abbrev-table exists but is not queried by
emacs-lisp-mode's abbrev-expand.
Maybe a bug?
Cheers
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: File lisp/abbrevlist.el
2011-03-23 8:31 ` Andreas Röhler
@ 2011-03-23 9:55 ` Leo
2011-03-23 19:47 ` Andreas Röhler
2011-03-24 1:39 ` Richard Stallman
1 sibling, 1 reply; 12+ messages in thread
From: Leo @ 2011-03-23 9:55 UTC (permalink / raw
To: emacs-devel
On 2011-03-23 16:31 +0800, Andreas Röhler wrote:
> Hi Leo,
>
> would consider it a potentially useful function though.
> Maybe put it into abbrev.el?
I wonder if insert-abbrev-table-description does something similar
already?
Leo
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: File lisp/abbrevlist.el
2011-03-23 1:15 File lisp/abbrevlist.el Leo
2011-03-23 8:31 ` Andreas Röhler
@ 2011-03-23 17:46 ` Stefan Monnier
2011-03-23 17:58 ` Leo
2011-03-23 18:14 ` Leo
1 sibling, 2 replies; 12+ messages in thread
From: Stefan Monnier @ 2011-03-23 17:46 UTC (permalink / raw
To: Leo; +Cc: emacs-devel
> I suggest obsolete/remove file lisp/abbrevlist.el since it contains a
> single broken function that nobody seems to use.
Obsoleting it sounds good, yes. In what way is it broken?
Stefan
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: File lisp/abbrevlist.el
2011-03-23 17:46 ` Stefan Monnier
@ 2011-03-23 17:58 ` Leo
2011-03-23 20:38 ` Stefan Monnier
2011-03-23 18:14 ` Leo
1 sibling, 1 reply; 12+ messages in thread
From: Leo @ 2011-03-23 17:58 UTC (permalink / raw
To: Stefan Monnier; +Cc: emacs-devel
On 2011-03-24 01:46 +0800, Stefan Monnier wrote:
> Obsoleting it sounds good, yes. In what way is it broken?
I didn't investigate further but this backtrace:
Debugger entered--Lisp error: (wrong-type-argument char-or-string-p nil)
list-one-abbrev-table([ 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 ...] "abc")
eval((list-one-abbrev-table text-mode-abbrev-table "abc"))
eval-expression((list-one-abbrev-table text-mode-abbrev-table "abc") nil)
call-interactively(eval-expression nil nil)
Leo
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: File lisp/abbrevlist.el
2011-03-23 17:46 ` Stefan Monnier
2011-03-23 17:58 ` Leo
@ 2011-03-23 18:14 ` Leo
1 sibling, 0 replies; 12+ messages in thread
From: Leo @ 2011-03-23 18:14 UTC (permalink / raw
To: emacs-devel
On 2011-03-24 01:46 +0800, Stefan Monnier wrote:
> Obsoleting it sounds good, yes.
Done in revision 103734.
Leo
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: File lisp/abbrevlist.el
2011-03-23 9:55 ` Leo
@ 2011-03-23 19:47 ` Andreas Röhler
2011-03-24 3:20 ` Leo
0 siblings, 1 reply; 12+ messages in thread
From: Andreas Röhler @ 2011-03-23 19:47 UTC (permalink / raw
To: Leo; +Cc: Emacs developers
Am 23.03.2011 10:55, schrieb Leo:
> On 2011-03-23 16:31 +0800, Andreas Röhler wrote:
>> Hi Leo,
>>
>> would consider it a potentially useful function though.
>> Maybe put it into abbrev.el?
>
> I wonder if insert-abbrev-table-description does something similar
> already?
>
> Leo
>
>
>
Think you are right.
BTW list-one-abbrev-table seems to have a bug.
Best regards,
Andreas
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: File lisp/abbrevlist.el
2011-03-23 17:58 ` Leo
@ 2011-03-23 20:38 ` Stefan Monnier
2011-03-24 3:20 ` Leo
0 siblings, 1 reply; 12+ messages in thread
From: Stefan Monnier @ 2011-03-23 20:38 UTC (permalink / raw
To: Leo; +Cc: emacs-devel
>> Obsoleting it sounds good, yes. In what way is it broken?
> I didn't investigate further but this backtrace:
> Debugger entered--Lisp error: (wrong-type-argument char-or-string-p nil)
> list-one-abbrev-table([ 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 ...]
> "abc")
> eval((list-one-abbrev-table text-mode-abbrev-table "abc"))
> eval-expression((list-one-abbrev-table text-mode-abbrev-table "abc") nil)
> call-interactively(eval-expression nil nil)
Ah, yes, so it's broken since Emacs-23.1 (since the introduction of the
new Elisp implementation of abbrevs). This probably means we can remove
it altogether.
Stefan
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: File lisp/abbrevlist.el
2011-03-23 8:31 ` Andreas Röhler
2011-03-23 9:55 ` Leo
@ 2011-03-24 1:39 ` Richard Stallman
1 sibling, 0 replies; 12+ messages in thread
From: Richard Stallman @ 2011-03-24 1:39 UTC (permalink / raw
To: Andreas Röhler; +Cc: sdl.web, emacs-devel
I created the file abbrevlist.el back when it was crucial to keep
the standard Emacs load as small as possible. Logically that function
belonged in abbrev.el, but it didn't need to be preloaded as abbrev.el is.
--
Dr Richard Stallman
President, Free Software Foundation
51 Franklin St
Boston MA 02110
USA
www.fsf.org, www.gnu.org
Skype: Don't use Skype, it's proprietary software!
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: File lisp/abbrevlist.el
2011-03-23 20:38 ` Stefan Monnier
@ 2011-03-24 3:20 ` Leo
2011-03-24 14:47 ` Stefan Monnier
0 siblings, 1 reply; 12+ messages in thread
From: Leo @ 2011-03-24 3:20 UTC (permalink / raw
To: emacs-devel
On 2011-03-24 04:38 +0800, Stefan Monnier wrote:
> Ah, yes, so it's broken since Emacs-23.1 (since the introduction of
> the new Elisp implementation of abbrevs).
Thus my claim 'nobody seems to use it' ;)
> This probably means we can remove it altogether.
I have already moved it to obsolete/. Do you want me to remove it
entirely?
Leo
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: File lisp/abbrevlist.el
2011-03-23 19:47 ` Andreas Röhler
@ 2011-03-24 3:20 ` Leo
0 siblings, 0 replies; 12+ messages in thread
From: Leo @ 2011-03-24 3:20 UTC (permalink / raw
To: emacs-devel
On 2011-03-24 03:47 +0800, Andreas Röhler wrote:
> BTW list-one-abbrev-table seems to have a bug.
Yes, it is broken for a while and nobody noticed.
Leo
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: File lisp/abbrevlist.el
2011-03-24 3:20 ` Leo
@ 2011-03-24 14:47 ` Stefan Monnier
0 siblings, 0 replies; 12+ messages in thread
From: Stefan Monnier @ 2011-03-24 14:47 UTC (permalink / raw
To: Leo; +Cc: emacs-devel
> I have already moved it to obsolete/. Do you want me to remove it
> entirely?
Let's remove it in Emacs-25.
Stfean
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2011-03-24 14:47 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-23 1:15 File lisp/abbrevlist.el Leo
2011-03-23 8:31 ` Andreas Röhler
2011-03-23 9:55 ` Leo
2011-03-23 19:47 ` Andreas Röhler
2011-03-24 3:20 ` Leo
2011-03-24 1:39 ` Richard Stallman
2011-03-23 17:46 ` Stefan Monnier
2011-03-23 17:58 ` Leo
2011-03-23 20:38 ` Stefan Monnier
2011-03-24 3:20 ` Leo
2011-03-24 14:47 ` Stefan Monnier
2011-03-23 18:14 ` Leo
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).