From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Leo Liu Newsgroups: gmane.emacs.devel Subject: Re: [ELPA-diffs] /srv/bzr/emacs/elpa r342: New package ggtags Date: Fri, 01 Feb 2013 02:03:06 +0800 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1359655413 11262 80.91.229.3 (31 Jan 2013 18:03:33 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 31 Jan 2013 18:03:33 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jan 31 19:03:53 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1U0yUI-0000fr-7J for ged-emacs-devel@m.gmane.org; Thu, 31 Jan 2013 19:03:50 +0100 Original-Received: from localhost ([::1]:35554 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U0yTz-0008IW-TF for ged-emacs-devel@m.gmane.org; Thu, 31 Jan 2013 13:03:31 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:45242) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U0yTt-0008I3-PJ for emacs-devel@gnu.org; Thu, 31 Jan 2013 13:03:29 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U0yTo-0001TU-UN for emacs-devel@gnu.org; Thu, 31 Jan 2013 13:03:25 -0500 Original-Received: from mail-pb0-f48.google.com ([209.85.160.48]:60724) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U0yTo-0001T8-Nk for emacs-devel@gnu.org; Thu, 31 Jan 2013 13:03:20 -0500 Original-Received: by mail-pb0-f48.google.com with SMTP id wy12so1725378pbc.35 for ; Thu, 31 Jan 2013 10:03:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:references:face:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=2daUwy69CeTlT5xTb7k3+JhEw3hbtx4VSUH+hQAsAsk=; b=pIbczxCZZmNJl3dRCGrKF/anv6v0w0eutZ8tq2tu/UM/CVG8nqBI+eiZk3+92XQ1x3 gdk5RY74x4WMGr+hHRl9IO8rdXYTJqOPgIv1LXyH076ucrSOoxMoXBZIlAEIuyLzztpd LRfckxrV2j8L+dCyRw3lXlIq/yJmoMj/mCHY3hsQpqgwmg9rEVK1eveHlofeOIE6qtl0 lDotUkBF0olrA7/gVmgS/RQe/3d21BwvWvowzsRgNnTaGty/2wysPgz9AHPYcmVd2KKS EkF8JbBPgflwTv8gS1RQuwnArnTQMG3tH2MVKLkjFhB4GbmXL85S/FitViIt9LW40Ldy L3UA== X-Received: by 10.66.76.130 with SMTP id k2mr22397960paw.76.1359655399655; Thu, 31 Jan 2013 10:03:19 -0800 (PST) Original-Received: from localhost ([182.48.109.8]) by mx.google.com with ESMTPS id sg7sm5658619pbb.3.2013.01.31.10.03.14 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Thu, 31 Jan 2013 10:03:18 -0800 (PST) Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAGFBMVEUKDAg1NjRWV1V9fnyg op/DxcLk5uP8/voi63ReAAAACXBIWXMAAAWJAAAFiQFtaJ36AAAAB3RJTUUH1goZAgAz00bgXgAA AeVJREFUKM9lk0Fz2jAQhQXJD3CCO70CmcC1YMtcWyTZ14Bl69xats4N9r6/3zWQBlodNKNPu/s0 b1cCQFuZGpfVVh3vAvBJolIXRkapSuoRUtIdFyo1Y5xSdlAj7OtvD1XnXxmWRi+eWgcxyCed1lVV B1CrKyujMoi+eLA5kU1SsjoHlW+nQjTtFxk4MXgrOxvIqzoTZR8XgPaLl419zgsMaSGFPiUOZCIh thsx5Xy9NsK8Kwf/JoQgMxcVJ301HKkcSWaT0O7FY056J4U9xcYfnmVXG4801lW6lqwu2nKFZoHC HuzvaTVndZ+LaRQgZdthXw1cpynEkLEwyFHXk/aIxNQ6QeooJuzPMB+wn+D7JJNsiCcVA13/A3h/ xE9J+WidpAwoYNmRFwyvSRhNVtsdaAewzZZP5uw82QL9+tyNfocyP0McAzICUr5Mk9RdIjWasUNx aIIt6NK4ZtXIMdfMQt3nuMAyWbLI4DqZ4xPq/ag8jPond4XU/cLuOgw6XCFX/YCUfcDAMMH58fD4 G9kDchwfqVefkBwup2uZM+Q4WhJt5jN3AxXCsaS2yXEDuWgS8VOzW0gFjhEPmLyFMKBFaLb1HRwc DiaKwx0EeTMRYnYPQRW3PP4HApvlMv0PttX5v/D6Aws3IOSEwzmLAAAAAElFTkSuQmCC In-Reply-To: (Stefan Monnier's message of "Thu, 31 Jan 2013 11:02:37 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.92 (OS X 10.8.2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 209.85.160.48 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:156744 Archived-At: On 2013-02-01 00:02 +0800, Stefan Monnier wrote: > I think this is a misuse of `assert'. An `assert' should be used for > something that should *never* be false (i.e. if it is false, we have > a bug, possibly in the assertion itself). This is reflected in the fact > that depending on optimization levels, CL can be told to "optimize-away" > the assertions. > > So I think you want to use an explicit "test + error" above. Thanks. I have fixed them. Leo