unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* How to submit a patch?
@ 2013-07-27 16:44 Willem Rein Oudshoorn
  2013-07-27 19:00 ` Glenn Morris
  0 siblings, 1 reply; 2+ messages in thread
From: Willem Rein Oudshoorn @ 2013-07-27 16:44 UTC (permalink / raw)
  To: emacs-devel

I was playing with images in emacs and discovered that the 
:foreground and :background properties for the image type XBM do not
work on the Cocoa version of emacs.

I have changed image.c nsimage.m and nsterm.h so it now
honors the attributes.

So how do I go about getting this incorperated in emacs?
I have used bzr to get the source, so what is the next step?

Also note that I did sign FSF copyright papers years and years ago,
but that was for the GNUstep project.  I am not sure if that is also
applicable to emacs.

Kind regards,
Wim Oudshoorn.





^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: How to submit a patch?
  2013-07-27 16:44 How to submit a patch? Willem Rein Oudshoorn
@ 2013-07-27 19:00 ` Glenn Morris
  0 siblings, 0 replies; 2+ messages in thread
From: Glenn Morris @ 2013-07-27 19:00 UTC (permalink / raw)
  To: Willem Rein Oudshoorn; +Cc: emacs-devel

Willem Rein Oudshoorn wrote:

> I was playing with images in emacs and discovered that the 
> :foreground and :background properties for the image type XBM do not
> work on the Cocoa version of emacs.
>
> I have changed image.c nsimage.m and nsterm.h so it now
> honors the attributes.
>
> So how do I go about getting this incorperated in emacs?

Please send the patch to bug-gnu-emacs@gnu.org, together with an
explanation of what problem it fixes.

> Also note that I did sign FSF copyright papers years and years ago,
> but that was for the GNUstep project.  I am not sure if that is also
> applicable to emacs.

No, that's only applicable for GNUstep, not for Emacs too.
Depending on how big the patch is, you might have to complete a new
assignment for Emacs. The first step is to send it as described above.



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-07-27 19:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-27 16:44 How to submit a patch? Willem Rein Oudshoorn
2013-07-27 19:00 ` Glenn Morris

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).