Re: master 0023891e842: Support hints in the :repeat keyword of defvar-keymap for repeat-mode

[Eshel Yaron <me@eshelyaron.com>]

JD Smith <jdtsmith@gmail.com> writes:

>>>  Lastly, it could be nice to make the appearance of the prompt more in
>>>  line with the read-multiple-choice prompt, which is conceptually very
>>>  similar.  Crucially, if the key is a character that occurs in the label,
>>>  it's better, IMO, to highlight the first occurrence of that character in
>>>  the label (as r-m-c does) than to prefix the label with that character.
>>>  We can reuse rmc--add-key-description for that purpose, as follows:
>>
>>  Nice idea.  A small problem is that when hints are not used,
>>  it inserts an extra space between the character and comma.

Well spotted.  How about something like the diff below?

> That will save some space.  Remember though that many times the key
> will not appear in the hint. In that case it would be nice to have a
> connector character of some kind, e.g. `|':expreg.

IIUC, the "connector character" in this example is the colon, right?  If
so, in read-multiple-choice we use a space as the connector character,
do you think a colon is preferable?


diff --git a/lisp/repeat.el b/lisp/repeat.el
index 412afc35ba7..efca965a533 100644
--- a/lisp/repeat.el
+++ b/lisp/repeat.el
@@ -558,14 +558,13 @@ repeat-echo-message-string
     (format-message
      "Repeat with %s%s"
      (mapconcat (lambda (key-cmd)
-                  (let* ((key (car key-cmd))
-                         (cmd (cdr key-cmd))
-                         (hint (when (symbolp cmd)
-                                 (get cmd 'repeat-hint))))
-                    (substitute-command-keys
-                     (format "\\`%s'%s"
-                             (key-description (vector key))
-                             (if hint (format ":%s" hint) "")))))
+                  (let ((key (car key-cmd))
+                        (cmd (cdr key-cmd)))
+                    (if-let ((hint (and (symbolp cmd)
+                                        (get cmd 'repeat-hint))))
+                        (cdr (rmc--add-key-description (list key hint)))
+                      (propertize (key-description (vector key))
+                                  'face 'read-multiple-choice-face))))
                 keys ", ")
      (if repeat-exit-key
          (substitute-command-keys