unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: arguments hint
Date: 02 Jun 2004 16:51:18 -0400	[thread overview]
Message-ID: <m1ise94rl6.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <200406022311.41897.pogonyshev@gmx.net>

> Meanwhile, I decided to practice with Elisp for a bit and came up with the
> following patch for eldoc-mode.  I assigned copyright to FSF, so if you like
> the patch, you can include it in Emacs.

Since we are in feature freeze, I think this patch will have to wait.

> The patch makes eldoc-mode highlight the current argument with bold face.
> Thus one can immediatly see which argument he stopped his point on.  This is
> maybe not very useful when typing new code, but should be helpful when
> editing something.  I took care to handle special cases like `&optional' or
> `&rest'.

I like this idea (even though it is pretty hairy to correctly process
&optional, [OPTARG], or even &key and such which can appear with functions
defined with CL's defun*).
When editing calls to completing-read and other such functions with many
parameters, it's really handy (although I'd prefer to use CL-style &key
parameters for those).

> As another, minor, change it highlights function/variable name with
> appropriate face.  This should help distinguishing between function and
> variable hints.

That doesn't strike me as terribly useful (the text is pretty different in
the two cases already).

> I'm not very familiar with Elisp, so maybe you'd like to review the patch.
> I will appreciate any feedback :)

I didn't dissect it, but it looks pretty good.


        Stefan

  reply	other threads:[~2004-06-02 20:51 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200406010011.16822.pogonyshev@gmx.net>
2004-06-02  3:45 ` arguments hint Richard Stallman
2004-06-02  5:58   ` Stefan Monnier
2004-06-02  6:30     ` Karl Chen
2004-06-02 13:42       ` Stefan Monnier
2004-06-02 22:55       ` Richard Stallman
2004-06-03 15:33         ` Karl Chen
2004-06-02 20:11     ` Paul Pogonyshev
2004-06-02 20:51       ` Stefan Monnier [this message]
2004-06-02 21:22         ` Paul Pogonyshev
2004-06-04 13:33           ` Paul Pogonyshev
2004-10-10  3:31             ` Stefan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m1ise94rl6.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).