From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eshel Yaron Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New package: dict Date: Thu, 18 May 2023 18:51:01 +0300 Message-ID: References: <834joj55pt.fsf@gnu.org> <87ednnvtt6.fsf@posteo.net> <875y8ywwko.fsf@posteo.net> <83zg69br5f.fsf@gnu.org> <83ednj9sw2.fsf@gnu.org> <837ct5x5v6.fsf@gnu.org> <83sfbtvii4.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21427"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: philipk@posteo.net, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu May 18 17:52:08 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pzfvE-0005JS-Il for ged-emacs-devel@m.gmane-mx.org; Thu, 18 May 2023 17:52:08 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pzfuM-0008Rn-6p; Thu, 18 May 2023 11:51:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pzfuJ-0008R1-L9 for emacs-devel@gnu.org; Thu, 18 May 2023 11:51:11 -0400 Original-Received: from mail.eshelyaron.com ([107.175.124.16] helo=eshelyaron.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pzfuF-00009r-Av; Thu, 18 May 2023 11:51:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1684425065; bh=uyfzqpMaNulRV26AVywFvlr9Kl26JcN1ZNEovDnwtBU=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=VxkU/8RRIzIk3JMiH1m2r6z7jSWQfOUiQX8e3pPzh95JsjnaLsfeJaYup5beRgFH0 hVzW4SmklqHFUVe3xqpib4dNZbfhoFaBmcsuArF0Wx+mYfvZTaoSs8YiIki3mKDKFB ubSf9yqKjUyNytgaDSQ6+r6eXK4oQPIJe5EVORLUJ+LH91fIQafi95DwnEE4MieHIg Yk81SBStB2bFPZG3AhVl69mT4U6eI4AFWze3Pynxc723FbR/qm+wKe56E3mdD2Eqtl /F3h+0THQGXSfHg1RatVoqjq3Q1ZHV8+DDW3SsC6ymXNlKWRw4Yx496JkK3jjrlzMe X2Q3PUNUQ+E7Q== In-Reply-To: <83sfbtvii4.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 18 May 2023 17:09:23 +0300") Received-SPF: pass client-ip=107.175.124.16; envelope-from=me@eshelyaron.com; helo=eshelyaron.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:306180 Archived-At: Eli Zaretskii writes: >> From: Eshel Yaron >> Cc: philipk@posteo.net, emacs-devel@gnu.org >> Date: Thu, 18 May 2023 15:21:31 +0300 >> >> Eli Zaretskii writes: >> >> >> --8<---------------cut here---------------start------------->8--- >> >> (setq dictionary-read-dictionary-function >> >> #'dictionary-completing-read-dictionary) >> >> (setq dictionary-read-word-function >> >> #'dictionary-completing-read-word) >> >> (setq dictionary-display-definition-function >> >> #'dictionary-display-definition-in-help-buffer) >> >> --8<---------------cut here---------------end--------------->8--- >> > >> > This looks excessive. How about adding yet another defcustom, with a >> > :set function, which will make all these adjustments for users who >> > want the words displayed in *Help*? >> >> I agree setting three options may be a bit much for casual users, but >> note that in order to display word definitions in *Help* you only need >> to customize the last option, `dictionary-display-definition-function`. >> The other two only affect the interactive word and dictionary selection >> (mostly adding completion), so I'm not sure it's necessary to couple >> them with how the definition ends up being presented. > > Then why did you add the other options? I've added these options in the patch because I want to have minibuffer completions in `dictionary-search`'s prompts, similarly to `dict-describe-word`. That's also why I mentioned all three customizations in my earlier message: to show how to obtain the behavior of `dict-describe-word` in dictionary.el using the new user options. But from the perspective of other dictionary.el users, it may be useful to customize each of the options but not the necessarily all of them. That's why I implemented them as separate user options. Makes sense? -- Best, Eshel