From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Stefan Newsgroups: gmane.emacs.devel Subject: Re: Please check-in Belanger's Calc patches Date: 21 Jul 2004 10:07:05 -0400 Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Message-ID: References: <87658qlgte.fsf@floss.red-bean.com> <87k6wyefvu.fsf@floss.red-bean.com> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1090418925 26331 80.91.224.253 (21 Jul 2004 14:08:45 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 21 Jul 2004 14:08:45 +0000 (UTC) Cc: Tacvek , Jay Belanger , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jul 21 16:08:28 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1BnHlk-0007aD-00 for ; Wed, 21 Jul 2004 16:08:28 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1BnHoW-0007vJ-8G for ged-emacs-devel@m.gmane.org; Wed, 21 Jul 2004 10:11:20 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1BnHoK-0007uv-Qp for emacs-devel@gnu.org; Wed, 21 Jul 2004 10:11:08 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1BnHo8-0007ru-VE for emacs-devel@gnu.org; Wed, 21 Jul 2004 10:11:08 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1BnHo8-0007rW-Ql for emacs-devel@gnu.org; Wed, 21 Jul 2004 10:10:56 -0400 Original-Received: from [206.47.199.141] (helo=simmts12-srv.bellnexxia.net) by monty-python.gnu.org with esmtp (Exim 4.34) id 1BnHkV-0003lh-3i for emacs-devel@gnu.org; Wed, 21 Jul 2004 10:07:11 -0400 Original-Received: from empanada.local ([67.70.164.151]) by simmts12-srv.bellnexxia.net (InterMail vM.5.01.06.10 201-253-122-130-110-20040306) with ESMTP id <20040721140637.FQFI1749.simmts12-srv.bellnexxia.net@empanada.local>; Wed, 21 Jul 2004 10:06:37 -0400 Original-Received: by empanada.local (Postfix, from userid 502) id 1B7572612CC; Wed, 21 Jul 2004 10:07:06 -0400 (EDT) Original-To: kfogel@red-bean.com In-Reply-To: <87k6wyefvu.fsf@floss.red-bean.com> Original-Lines: 12 User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:25861 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:25861 [...] > calc-invocation-macro, calc-show-banner): Define these as part of > `calc-mode-var-list's initialization, instead of using defvar. Not defining those vars with defvar means that the byte-compiler doesn't get the info it wants. It doesn't necessarily lead to wrong code, but it's very bad coding style and can prevent optimizations (which are admittedly not currently implemented). It also leads to lots and lots of spurious warnings during byte-compilation. Stefan