From: Stefan <monnier@iro.umontreal.ca>
Cc: Tacvek <unknown_kev_cat@hotmail.com>,
Jay Belanger <belanger@truman.edu>,
emacs-devel@gnu.org
Subject: Re: Please check-in Belanger's Calc patches
Date: 21 Jul 2004 10:07:05 -0400 [thread overview]
Message-ID: <m1hds1lam7.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87k6wyefvu.fsf@floss.red-bean.com>
[...]
> calc-invocation-macro, calc-show-banner): Define these as part of
> `calc-mode-var-list's initialization, instead of using defvar.
Not defining those vars with defvar means that the byte-compiler doesn't
get the info it wants. It doesn't necessarily lead to wrong code, but it's
very bad coding style and can prevent optimizations (which are admittedly
not currently implemented). It also leads to lots and lots of spurious
warnings during byte-compilation.
Stefan
next prev parent reply other threads:[~2004-07-21 14:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-13 16:09 Please check-in Belanger's Calc patches Tacvek
2004-07-13 17:42 ` Karl Fogel
2004-07-14 3:40 ` Jay Belanger
2004-07-14 18:27 ` Richard Stallman
2004-07-14 16:00 ` Karl Fogel
2004-07-20 17:40 ` Karl Fogel
2004-07-21 14:07 ` Stefan [this message]
2004-07-21 14:59 ` Jay Belanger
2004-07-21 15:44 ` Stefan Monnier
2004-07-21 17:16 ` Jay Belanger
2004-07-21 17:42 ` Jay Belanger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1hds1lam7.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=belanger@truman.edu \
--cc=emacs-devel@gnu.org \
--cc=unknown_kev_cat@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).