From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: font-lock-comment-delimiter-face Date: Tue, 26 Apr 2005 16:58:40 -0400 Message-ID: References: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1114549259 29121 80.91.229.2 (26 Apr 2005 21:00:59 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 26 Apr 2005 21:00:59 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Apr 26 23:00:58 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DQX8E-00070p-Df for ged-emacs-devel@m.gmane.org; Tue, 26 Apr 2005 22:58:11 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DQXE1-00009m-FB for ged-emacs-devel@m.gmane.org; Tue, 26 Apr 2005 17:04:09 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DQXAr-0007Ze-Me for emacs-devel@gnu.org; Tue, 26 Apr 2005 17:00:53 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DQXAq-0007ZE-Nd for emacs-devel@gnu.org; Tue, 26 Apr 2005 17:00:53 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DQXAq-0008GE-7R for emacs-devel@gnu.org; Tue, 26 Apr 2005 17:00:52 -0400 Original-Received: from [206.47.199.165] (helo=simmts7-srv.bellnexxia.net) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DQXCW-0008Ga-Oi; Tue, 26 Apr 2005 17:02:36 -0400 Original-Received: from empanada.home ([65.92.240.194]) by simmts7-srv.bellnexxia.net (InterMail vM.5.01.06.10 201-253-122-130-110-20040306) with ESMTP id <20050426205840.KCXC3701.simmts7-srv.bellnexxia.net@empanada.home>; Tue, 26 Apr 2005 16:58:40 -0400 Original-Received: by empanada.home (Postfix, from userid 502) id 6783352FD6C; Tue, 26 Apr 2005 16:58:40 -0400 (EDT) Original-To: rms@gnu.org In-Reply-To: (Richard Stallman's message of "Sat, 23 Apr 2005 18:51:38 -0400") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (darwin) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:36420 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:36420 > I introduced a new face, font-lock-comment-delimiter-face, > to make it possible to customize separately the fontification > of comment delimiters and comment text. I also set up Rmail > and Sendmail modes to use this. Seems odd to introduce a new face whose name refers to "comment" even though the only two known uses for it are not for comments but for email citations. > However, lots of other modes ought to be set up to use it. > Can people please go to work on those modes? It could be directly added in a generic way to font-lock-fontify-syntactically-region. But really, I haven't seen much of a need for such fine-grained font-locking of comment delimiters. I'm surprised you opted for such a disruptive "solution" to your problem, when a much simpler one was proposed. I.e. I'd have much preferred the introduction of a new mail-citation-face (message has one already called message-cited-text-face), which could by defaut just inherit from font-lock-comment-face but which you could change to be more legible for your specific needs. You wouldn't get the specific look you currently have, but it might be good enough, and if not, you can always get your particular look using font-lock-add-keywords. Stefan