From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eshel Yaron Newsgroups: gmane.emacs.devel Subject: Re: master c3e989ca9d7: New minor mode find-function-mode replaces find-function-setup-keys Date: Fri, 04 Oct 2024 13:57:00 +0200 Message-ID: References: <172800172214.1813703.15067539931889719779@vcs3.savannah.gnu.org> <20241004002843.024A41867DE@vcs3.savannah.gnu.org> <87v7y8ywok.fsf@melete.silentflame.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8494"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Sean Whitton Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Oct 04 13:57:43 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1swgwI-00024X-Sz for ged-emacs-devel@m.gmane-mx.org; Fri, 04 Oct 2024 13:57:42 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1swgvg-0004RO-Vf; Fri, 04 Oct 2024 07:57:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1swgvg-0004RF-F3 for emacs-devel@gnu.org; Fri, 04 Oct 2024 07:57:04 -0400 Original-Received: from mail.eshelyaron.com ([107.175.124.16] helo=eshelyaron.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1swgvf-0004y1-38 for emacs-devel@gnu.org; Fri, 04 Oct 2024 07:57:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1728043022; bh=7Bd3TpsLEqpAGyQZ3shml9w38pTtjDOzU7sU8Y02jdg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=pj7rf8aPkk79pRH3Ufv5ozRqBcVBZx6rNDWv+OxJWqESAaVpVHEubSgnf//Fk7wqw fqarHtLxZKSLnjM436BK7yudW2Mfev6Ijakn6ETofb0PJOYUzJ4TBSK6SK79KyJ3qP bgrxfHSkjAknHorbssFkgyG0M4RANzIE1NViw0HXE6J8EmVB0o818YMBP5ZTN9ETWr uKDwN1aE4w64A4ZzIEmtR5gdNEdPLpRilf8MNPEMTQOqzgZLLGoDss7w/iaGdjpbN2 fHr4GWh3Hdo3I2ZYLSpCyExN3w7/BNZXTVMjQSZXSFYcQZvoyLmfBqGsQYEUTh3gJ5 fMdVSgqkCOUcA== In-Reply-To: <87v7y8ywok.fsf@melete.silentflame.com> (Sean Whitton's message of "Fri, 04 Oct 2024 18:44:27 +0800") Received-SPF: pass client-ip=107.175.124.16; envelope-from=me@eshelyaron.com; helo=eshelyaron.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:324314 Archived-At: Sean Whitton writes: > On Fri 04 Oct 2024 at 11:56am +02, Eshel Yaron wrote: > >> Hmm this changes the precedence of these bindings from low (global map) >> to very high (minor mode map). So it's actually quite a breaking change >> for those of us that use find-function-setup-keys and override these >> bindings in certain major mode maps :/ >> >> How about keeping the behavior of find-function-setup-keys as it was? >> We can keep that minor mode too, of course. > > Ah, that was not intentional. Thanks for pointing this out. > > One option is just to keep find-function-setup-keys as it was. > Another would be to make the minor mode add the keys to the global map, > and remove them from it when deactivated. How about that? The first option might be slightly simpler, but either way works for my use case, I think. Thanks, Eshel