From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Daniel_Mart=C3=ADn?= Newsgroups: gmane.emacs.devel Subject: Re: master 262d0c6: Mark some tests as expensive Date: Sat, 12 Sep 2020 17:16:19 +0200 Message-ID: References: <20200910182904.20559.25935@vcs0.savannah.gnu.org> <20200910182905.F0E4520A2E@vcs0.savannah.gnu.org> <877dt0is0p.fsf@gmx.de> <83a6xve0vq.fsf@gnu.org> <83tuw3ccba.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13722"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (darwin) Cc: stefan@marxist.se, michael.albinus@gmx.de, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Sep 12 17:17:22 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kH7HF-0003U2-RL for ged-emacs-devel@m.gmane-mx.org; Sat, 12 Sep 2020 17:17:21 +0200 Original-Received: from localhost ([::1]:49560 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kH7HE-0006EY-Sq for ged-emacs-devel@m.gmane-mx.org; Sat, 12 Sep 2020 11:17:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45752) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kH7GS-0005Wc-9C for emacs-devel@gnu.org; Sat, 12 Sep 2020 11:16:32 -0400 Original-Received: from sonic313-20.consmr.mail.ir2.yahoo.com ([77.238.179.187]:32772) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kH7GQ-0004fr-9u for emacs-devel@gnu.org; Sat, 12 Sep 2020 11:16:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.es; s=s2048; t=1599923788; bh=bfd9XKc0DYWpynKWok9ZX8Rg0q/qDyZY2EWR+aaX9lw=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject; b=orb5bBeItFd1aukkiR9uQgEufvcbEvY+h/jtf/Oxs/eCl8i5nTR4OkWgu4oz6Ukyn00SEb5G2cn1ZogEbRDsCU6yBQOf9chOgO7QjbYwFSbQiKsZNBFZ9XagOXr2s4EProVQA+3kdN2J5fGa4SUFqJYWAUGoyqtmP03E7xezDagdxDzI31rafQRzmb1vnCq73/M1aA1FqjTRqJ+hfxbsQ5BIcamN4sXvGuLAXeYlDgazjq87VEbZp4ql/kfa+jGRUpcUxCf53lBuz+PmEQrrttU6GSjHPpbwjb6D8hyk27cedIoNKjLub2DNkDdvHrqoZvMOU/lJq+4F20H3s9imuQ== X-YMail-OSG: ETKgWHsVM1mNHkBbRZsFlDwGX5swp_GHqDEVfGWtxJoxBPTPtCv8_DCmyYBSRYq BEXxAOZ5vfDZKPvFqGEol.pznVs_m.Vphvt508EbJZW1HcShRFdJPTGXdpmQky7dCDbNxgvzuLse xaar0kFY3QyIjSzzCPdH_RY5Yo5_aaM7Hg99SoFynTJleJ76BrncJPawzioYIOscupthmkpBpsiz NyDvfk_1zHTe1Bmne48g6_SSqPS5qG4FF8HC4QBihE9GHnI3StCwgYUT9LByaLE5HVfOCBKaqcZB _uo1aB5szDaGauXmn4HwYdj6tNonXN.6LIo.RfPbmUnu1WBMekBSqAvLxwELYzgeVvAzmR2yZaSf Vn8QYMu0CEPWEQgZ4pnMYwSokbOHG0Az3EP4B41w31qPXFfnxCWOEIftaVWpzfwEzQX2bMM8gPpG ley.yzp2YYG4NOv3Vn3hb_nB.Bx7AuoqcQEuu.5froB7pGSw9_VftXEO578cDzlcLZ_RRThpBb0h IiR_f2ipXFjSWTex1z1.MuogPK36GoYS4uHqEnnx7PpK_QyFLRGFbCe_L3T69e0aSbuOBU4Jqdrm 5YU.qHlUg5gmjJbMza5Uf5Mkq4fwyvmfvzIJRV2YEAhZ0GSFlk2ukGc8cnYiKpfVvOsMUKaseQSR 2uAAkNHaGEJv7r63g9JYuABzq1a11Nttlb7nmfJZVO5qEvP9VJr.hssVKxfdsS4.DdzgTxMRDM2S UixD0eh.2kFhwG7ihh8Z_ZHff0fF6vJhPSgVazVSfvc4XZcDjPNSICybVwcGKevPv.B5EbXuBrHK XRxW_8TL4jCoIagFgrVIz9c.4p0bxI9PmKpPYVVueC Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic313.consmr.mail.ir2.yahoo.com with HTTP; Sat, 12 Sep 2020 15:16:28 +0000 Original-Received: by smtp413.mail.ir2.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 168aad4af1d1a94e00a69a35589ceac7; Sat, 12 Sep 2020 15:16:22 +0000 (UTC) In-Reply-To: <83tuw3ccba.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 12 Sep 2020 17:14:01 +0300") X-Mailer: WebService/1.1.16565 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Apache-HttpAsyncClient/4.1.4 (Java/11.0.7) Received-SPF: pass client-ip=77.238.179.187; envelope-from=mardani29@yahoo.es; helo=sonic313-20.consmr.mail.ir2.yahoo.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/12 10:00:16 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:255370 Archived-At: Eli Zaretskii writes: > > I don't understand what you are arguing here. AFAIK, Michael already > either marked "unstable" or rewrote any tests that are known to suffer > from non-determinism. Slow speed doesn't necessarily add > non-determinism, not if Emacs waits for the operation to complete. > > So I don't see how this is relevant to the issue at hand, which is the > criteria for marking tests "expensive" and not running them by > default. What am I missing? After reading "Tramp tests need more time because they involve a remote system" I assumed that those tests were accessing real hosts using the network. That's why I mentioned the importance of determinism in tests. Michael has pointed out that network connections are correctly "mocked" in "make check", which seems fine.