Re: master c3e989ca9d7: New minor mode find-function-mode replaces find-function-setup-keys

[Eshel Yaron <me@eshelyaron.com>]

Hi,

Sean Whitton <spwhitton@spwhitton.name> writes:

> branch: master
> commit c3e989ca9d786e001a9801fdd95fcbcb0d73fddc
> Author: Sean Whitton <spwhitton@spwhitton.name>
> Commit: Sean Whitton <spwhitton@spwhitton.name>
>
>     New minor mode find-function-mode replaces find-function-setup-keys
>     
>     * lisp/emacs-lisp/find-func.el (find-function-mode-map):
>     (find-function-mode): New minor mode.
>     (find-function-setup-keys): Replace with stub function that just
>     enables the new minor mode.  Mark as obsolete.

[...]

> +(defvar-keymap find-function-mode-map
> +  "C-x F"   #'find-function
> +  "C-x 4 F" #'find-function-other-window
> +  "C-x 5 F" #'find-function-other-frame
> +
> +  "C-x K"   #'find-function-on-key
> +  "C-x 4 K" #'find-function-on-key-other-window
> +  "C-x 5 K" #'find-function-on-key-other-frame
> +
> +  "C-x V"   #'find-variable
> +  "C-x 4 V" #'find-variable-other-window
> +  "C-x 5 V" #'find-variable-other-frame
> +
> +  "C-x L"   #'find-library
> +  "C-x 4 L" #'find-library-other-window
> +  "C-x 5 L" #'find-library-other-frame)
> +
> +;;;###autoload
> +(define-minor-mode find-function-mode
> +  "Enable some key bindings for the `find-function' family of functions."
> +  :global t :lighter nil   ; compat. with old `find-function-setup-keys'
> +  :group 'find-function :version "31.1")
> +
>  ;;;###autoload
>  (defun find-function-setup-keys ()
> -  "Define some key bindings for the `find-function' family of functions."
> -  (define-key ctl-x-map "F" 'find-function)
> -  (define-key ctl-x-4-map "F" 'find-function-other-window)
> -  (define-key ctl-x-5-map "F" 'find-function-other-frame)
> -  (define-key ctl-x-map "K" 'find-function-on-key)
> -  (define-key ctl-x-4-map "K" 'find-function-on-key-other-window)
> -  (define-key ctl-x-5-map "K" 'find-function-on-key-other-frame)
> -  (define-key ctl-x-map "V" 'find-variable)
> -  (define-key ctl-x-4-map "V" 'find-variable-other-window)
> -  (define-key ctl-x-5-map "V" 'find-variable-other-frame)
> -  (define-key ctl-x-map "L" 'find-library)
> -  (define-key ctl-x-4-map "L" 'find-library-other-window)
> -  (define-key ctl-x-5-map "L" 'find-library-other-frame))
> +  "Turn on `find-function-mode', which see."
> +  (find-function-mode 1))
> +(make-obsolete 'find-function-setup-keys 'find-function-mode "31.1")
>  
>  (provide 'find-func)

Hmm this changes the precedence of these bindings from low (global map)
to very high (minor mode map).  So it's actually quite a breaking change
for those of us that use find-function-setup-keys and override these
bindings in certain major mode maps :/

How about keeping the behavior of find-function-setup-keys as it was?
We can keep that minor mode too, of course.


Best,

Eshel