From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Stefan Newsgroups: gmane.emacs.devel Subject: Re: compilation-mode makes the buffer read-only Date: Tue, 02 Nov 2004 07:11:00 -0500 Message-ID: References: NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1099397533 3669 80.91.229.6 (2 Nov 2004 12:12:13 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 2 Nov 2004 12:12:13 +0000 (UTC) Cc: occitan@esperanto.org, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Nov 02 13:12:07 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1COxWA-0005oN-00 for ; Tue, 02 Nov 2004 13:12:07 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1COxeD-00066j-Hz for ged-emacs-devel@m.gmane.org; Tue, 02 Nov 2004 07:20:25 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1COxdh-00065p-Lu for emacs-devel@gnu.org; Tue, 02 Nov 2004 07:19:54 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1COxdg-00064q-79 for emacs-devel@gnu.org; Tue, 02 Nov 2004 07:19:52 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1COxdf-00064f-Kh for emacs-devel@gnu.org; Tue, 02 Nov 2004 07:19:51 -0500 Original-Received: from [206.47.199.166] (helo=simmts8-srv.bellnexxia.net) by monty-python.gnu.org with esmtp (Exim 4.34) id 1COxVM-0006QW-8Q; Tue, 02 Nov 2004 07:11:17 -0500 Original-Received: from empanada.home ([67.71.24.49]) by simmts8-srv.bellnexxia.net (InterMail vM.5.01.06.10 201-253-122-130-110-20040306) with ESMTP id <20041102121101.QDJG1692.simmts8-srv.bellnexxia.net@empanada.home>; Tue, 2 Nov 2004 07:11:01 -0500 Original-Received: by empanada.home (Postfix, from userid 502) id 024E035040B; Tue, 2 Nov 2004 07:11:00 -0500 (EST) Original-To: rms@gnu.org In-Reply-To: (Richard Stallman's message of "Tue, 02 Nov 2004 03:53:25 -0500") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/21.3.50 (darwin) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:29317 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:29317 > Your change would turn on buffer-read-only for modes other than > compilation-mode. That does not seem desirable. Presumably these other modes all derive from compilation-mode (i.e. things like grep-mode), so they already are put in read-only mode. But I agree that I don't understand the code well enough to know for sure the implications of my change, hence my question. > What is your intent here? As mentioned the change * progmodes/compile.el (compilation-start): Assume compilation-mode will make the buffer read-only. (compilation-mode): Take arg name-of-mode. (compilation-setup): Make buffer read-only. (compilation-handle-exit): Bind inhibit-read-only. makes the buffer read-only in cases where it is not expected. This was already partly fixed by making the buffer read-only for the non-minor-mode case only, and my change intended to further reduce the number of cases where the buffer is made read-only by moving it to `compilation-start'. Stefan