unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan <monnier@iro.umontreal.ca>
Cc: occitan@esperanto.org, emacs-devel@gnu.org
Subject: Re: compilation-mode makes the buffer read-only
Date: Tue, 02 Nov 2004 07:11:00 -0500	[thread overview]
Message-ID: <m1d5ywh2zt.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <E1COuPt-00017v-L9@fencepost.gnu.org> (Richard Stallman's message of "Tue, 02 Nov 2004 03:53:25 -0500")

> Your change would turn on buffer-read-only for modes other than
> compilation-mode.  That does not seem desirable.

Presumably these other modes all derive from compilation-mode
(i.e. things like grep-mode), so they already are put in read-only mode.
But I agree that I don't understand the code well enough to know for sure
the implications of my change, hence my question.

> What is your intent here?

As mentioned the change

	* progmodes/compile.el (compilation-start): Assume compilation-mode
	will make the buffer read-only.
	(compilation-mode): Take arg name-of-mode.
	(compilation-setup): Make buffer read-only.
	(compilation-handle-exit): Bind inhibit-read-only.

makes the buffer read-only in cases where it is not expected.  This was
already partly fixed by making the buffer read-only for the non-minor-mode
case only, and my change intended to further reduce the number of cases
where the buffer is made read-only by moving it to `compilation-start'.


        Stefan

  reply	other threads:[~2004-11-02 12:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-31 23:05 compilation-mode makes the buffer read-only Stefan
2004-11-01  8:01 ` Daniel Pfeiffer
2004-11-02  8:53 ` Richard Stallman
2004-11-02 12:11   ` Stefan [this message]
2004-11-03 12:45     ` Richard Stallman
2004-11-03 14:16       ` Stefan Monnier
2004-11-04  9:51         ` Richard Stallman
2004-11-05  8:05           ` Stefan
2004-11-09 11:14             ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m1d5ywh2zt.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=occitan@esperanto.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).