* Re: master e6161f6: * lisp/emacs-lisp/inline.el: Fix apply-conversion (bug#25280) [not found] ` <20161227174437.B08552201C7@vcs.savannah.gnu.org> @ 2016-12-28 1:38 ` Leo Liu 2016-12-28 2:37 ` Stefan Monnier 0 siblings, 1 reply; 5+ messages in thread From: Leo Liu @ 2016-12-28 1:38 UTC (permalink / raw) To: emacs-devel; +Cc: Stefan Monnier On 2016-12-27 17:44 +0000, Stefan Monnier wrote: > branch: master > commit e6161f648903d821865b9610b3b6aa0f82a5dcb7 > Author: Stefan Monnier <monnier@iro.umontreal.ca> > Commit: Stefan Monnier <monnier@iro.umontreal.ca> > > * lisp/emacs-lisp/inline.el: Fix apply-conversion (bug#25280) > > (inline--dont-quote): Quote the function with #' when passing it to `apply'. > --- > lisp/emacs-lisp/inline.el | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/lisp/emacs-lisp/inline.el b/lisp/emacs-lisp/inline.el > index 058c56c..5ceb0d9 100644 > --- a/lisp/emacs-lisp/inline.el > +++ b/lisp/emacs-lisp/inline.el > @@ -191,9 +191,9 @@ After VARS is handled, BODY is evaluated in the new environment." > (while (and (consp exp) (not (eq '\, (car exp)))) > (push (inline--dont-quote (pop exp)) args)) > (setq args (nreverse args)) > - (if exp > - `(apply ,@args ,(inline--dont-quote exp)) > - args))) > + (if (null exp) > + args > + `(apply #',(car args) ,@(cdr args) ,(inline--dont-quote exp))))) > (_ exp))) > > (defun inline--do-leteval (var-exp &rest body) > Could we have this bug fixed in emacs-25? inline.el is new in 25.1 and broken. We should make sure 25.x have a usable version. Thoughts? Leo ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: master e6161f6: * lisp/emacs-lisp/inline.el: Fix apply-conversion (bug#25280) 2016-12-28 1:38 ` master e6161f6: * lisp/emacs-lisp/inline.el: Fix apply-conversion (bug#25280) Leo Liu @ 2016-12-28 2:37 ` Stefan Monnier 2016-12-28 4:43 ` John Wiegley 0 siblings, 1 reply; 5+ messages in thread From: Stefan Monnier @ 2016-12-28 2:37 UTC (permalink / raw) To: Leo Liu; +Cc: emacs-devel > Could we have this bug fixed in emacs-25? inline.el is new in 25.1 and > broken. We should make sure 25.x have a usable version. Thoughts? The patch applies to emacs-25 just fine, and I can't imagine how it could break currently working code, so it can definitely go there. But I'll let Eli and John decide if they want it: it's not very urgent. Stefan ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: master e6161f6: * lisp/emacs-lisp/inline.el: Fix apply-conversion (bug#25280) 2016-12-28 2:37 ` Stefan Monnier @ 2016-12-28 4:43 ` John Wiegley 2016-12-28 15:42 ` Eli Zaretskii 0 siblings, 1 reply; 5+ messages in thread From: John Wiegley @ 2016-12-28 4:43 UTC (permalink / raw) To: Stefan Monnier; +Cc: Leo Liu, emacs-devel >>>>> "SM" == Stefan Monnier <monnier@iro.umontreal.ca> writes: SM> The patch applies to emacs-25 just fine, and I can't imagine how it could SM> break currently working code, so it can definitely go there. But I'll let SM> Eli and John decide if they want it: it's not very urgent. If Eli's fine with it, it looks harmless enough to me. -- John Wiegley GPG fingerprint = 4710 CF98 AF9B 327B B80F http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2 ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: master e6161f6: * lisp/emacs-lisp/inline.el: Fix apply-conversion (bug#25280) 2016-12-28 4:43 ` John Wiegley @ 2016-12-28 15:42 ` Eli Zaretskii 2016-12-28 16:51 ` Stefan Monnier 0 siblings, 1 reply; 5+ messages in thread From: Eli Zaretskii @ 2016-12-28 15:42 UTC (permalink / raw) To: John Wiegley; +Cc: emacs-devel, monnier, sdl.web > From: John Wiegley <jwiegley@gmail.com> > Date: Tue, 27 Dec 2016 20:43:42 -0800 > Cc: Leo Liu <sdl.web@gmail.com>, emacs-devel@gnu.org > > >>>>> "SM" == Stefan Monnier <monnier@iro.umontreal.ca> writes: > > SM> The patch applies to emacs-25 just fine, and I can't imagine how it could > SM> break currently working code, so it can definitely go there. But I'll let > SM> Eli and John decide if they want it: it's not very urgent. > > If Eli's fine with it, it looks harmless enough to me. No objections here. Thanks. ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: master e6161f6: * lisp/emacs-lisp/inline.el: Fix apply-conversion (bug#25280) 2016-12-28 15:42 ` Eli Zaretskii @ 2016-12-28 16:51 ` Stefan Monnier 0 siblings, 0 replies; 5+ messages in thread From: Stefan Monnier @ 2016-12-28 16:51 UTC (permalink / raw) To: Eli Zaretskii; +Cc: John Wiegley, sdl.web, emacs-devel Done, thanks, Stefan >>>>> "Eli" == Eli Zaretskii <eliz@gnu.org> writes: >> From: John Wiegley <jwiegley@gmail.com> >> Date: Tue, 27 Dec 2016 20:43:42 -0800 >> Cc: Leo Liu <sdl.web@gmail.com>, emacs-devel@gnu.org >> >> >>>>> "SM" == Stefan Monnier <monnier@iro.umontreal.ca> writes: >> SM> The patch applies to emacs-25 just fine, and I can't imagine how it could SM> break currently working code, so it can definitely go there. But I'll let SM> Eli and John decide if they want it: it's not very urgent. >> >> If Eli's fine with it, it looks harmless enough to me. > No objections here. > Thanks. ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-12-28 16:51 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20161227174437.22152.97374@vcs.savannah.gnu.org>
[not found] ` <20161227174437.B08552201C7@vcs.savannah.gnu.org>
2016-12-28 1:38 ` master e6161f6: * lisp/emacs-lisp/inline.el: Fix apply-conversion (bug#25280) Leo Liu
2016-12-28 2:37 ` Stefan Monnier
2016-12-28 4:43 ` John Wiegley
2016-12-28 15:42 ` Eli Zaretskii
2016-12-28 16:51 ` Stefan Monnier
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).