From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Leo Liu Newsgroups: gmane.emacs.devel Subject: Re: master e6161f6: * lisp/emacs-lisp/inline.el: Fix apply-conversion (bug#25280) Date: Wed, 28 Dec 2016 09:38:12 +0800 Message-ID: References: <20161227174437.22152.97374@vcs.savannah.gnu.org> <20161227174437.B08552201C7@vcs.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1482889119 571 195.159.176.226 (28 Dec 2016 01:38:39 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 28 Dec 2016 01:38:39 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (macOS 10.12.2) Cc: Stefan Monnier To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Dec 28 02:38:35 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cM3CF-0007DY-Mu for ged-emacs-devel@m.gmane.org; Wed, 28 Dec 2016 02:38:27 +0100 Original-Received: from localhost ([::1]:56934 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cM3CK-0000K5-5J for ged-emacs-devel@m.gmane.org; Tue, 27 Dec 2016 20:38:32 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33275) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cM3CA-0000K0-W2 for emacs-devel@gnu.org; Tue, 27 Dec 2016 20:38:23 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cM3C7-0001Lp-Lr for emacs-devel@gnu.org; Tue, 27 Dec 2016 20:38:22 -0500 Original-Received: from mail-pg0-x243.google.com ([2607:f8b0:400e:c05::243]:33644) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cM3C7-0001Ll-Fm for emacs-devel@gnu.org; Tue, 27 Dec 2016 20:38:19 -0500 Original-Received: by mail-pg0-x243.google.com with SMTP id g1so14004709pgn.0 for ; Tue, 27 Dec 2016 17:38:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:face:date:in-reply-to:message-id :user-agent:mime-version; bh=oo2pVIRpbJRykUjTqVku51DgIfPs/FoXy0UdaXhIDm0=; b=vHzWDggDVz32vwV/hb51PbZOjmtl0lC6Sy3ds6JT4ySbgGN+7pZrcX5M87AaI20VlY crPvQEhYIASHhJ2wiZuSMJ5oT3PC3J4xh3uhnuer1Py/41ceKS69dcrORAphd30VmGRZ HqJmDwjXpyETMKZA3zindy3tS2/WDnlv/cs8OCej99GYFjKuEI5ZSFyarr8HbCc4YOCg PDYJln0BljSkcvzMwf4Sfac2IjwZwC4UxEXX1i1RlfR98JZyipwLvsHCfe48bl0lzSqB wk/HUOELysLvXueqygZHZtau4Pj+7fiBXQzRYnkCt0ejj16a3fdYsA0zzDtSDCuqbYd9 /3vA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:face:date :in-reply-to:message-id:user-agent:mime-version; bh=oo2pVIRpbJRykUjTqVku51DgIfPs/FoXy0UdaXhIDm0=; b=h4/ih+xXVsf1oSmIw9YMpSDjA9res+UFRkeo/BRQFZxXZobo9fgQEd8zCdoqVIiGNG lY2AT8mzIA/6KChSvxLblywmOH03bkmjYLjmH8l2BmpKMxgf33NkM2ih0prBaT5z7+27 imeEklciMX9j6QYECtKOeeCZi7C9C4HtfdCClL9LLDtsO92H6tRPdL28LqD5G4Zc9ycS otvpWol9l7reR4wZY8jrbp0xksxiqu9HFouXBIMDEYeZHKtFT5abdOEbmdBaONMBnHjl GWiFQL0SAzTkMf7cS7C988bskiirppwadPz8pBGHH+AwlpQ6dshTqXNdlJJ4WgZvHbbp MCBw== X-Gm-Message-State: AIkVDXK5FHCxDGAjtkZJQF2MUNIQicyP1ZFpburIduqXIdzAYUIFqehuju1a7btvdx/k7g== X-Received: by 10.84.148.134 with SMTP id k6mr71345335pla.57.1482889098436; Tue, 27 Dec 2016 17:38:18 -0800 (PST) Original-Received: from Zeuss-MacBook-Air.local ([112.208.1.100]) by smtp.gmail.com with ESMTPSA id t67sm92272628pfg.13.2016.12.27.17.38.15 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 27 Dec 2016 17:38:17 -0800 (PST) Face: iVBORw0KGgoAAAANSUhEUgAAACkAAAApAQAAAACAGz1bAAABKElEQVQYlWNg3NIt5FDPUPt7 4+X79Qyucz5/ugik+L2PBgKpyphaIK921q23QDnG0NBQoMr/vaWl9f8ZLL78uPv5PwN7RETfzXoG jhmFz27XM0RXmpuY/WfY+fv0Mc56BvFybfXA/wwL5t/wF61n2PU59axXPcOVzbmSW/8zrNt1benC /ww70hqUU/4zKCtrT9jwn8FhwynbufUMendE2aLqGRpdX9al1zM8eh17lKeeQcTMrdD5P8P3j/YT Q/8zXHSb7p1Qz/C4OM2JuZ7hgtI7K6AjqsMnf8j4z8C6xG1tw3+GqpqvsVn/GTzmpD9j/8/wP/oZ S/l/Bka+QO/g/wy15ueeFQL9N1O8mPU/g+umV3t1gdT0/1bTgHLqYVeXAlWKpMWt+w8Az82C9nHf X0cAAAAASUVORK5CYII= In-Reply-To: <20161227174437.B08552201C7@vcs.savannah.gnu.org> (Stefan Monnier's message of "Tue, 27 Dec 2016 17:44:37 +0000 (UTC)") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400e:c05::243 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:210855 Archived-At: On 2016-12-27 17:44 +0000, Stefan Monnier wrote: > branch: master > commit e6161f648903d821865b9610b3b6aa0f82a5dcb7 > Author: Stefan Monnier > Commit: Stefan Monnier > > * lisp/emacs-lisp/inline.el: Fix apply-conversion (bug#25280) > > (inline--dont-quote): Quote the function with #' when passing it to `apply'. > --- > lisp/emacs-lisp/inline.el | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/lisp/emacs-lisp/inline.el b/lisp/emacs-lisp/inline.el > index 058c56c..5ceb0d9 100644 > --- a/lisp/emacs-lisp/inline.el > +++ b/lisp/emacs-lisp/inline.el > @@ -191,9 +191,9 @@ After VARS is handled, BODY is evaluated in the new environment." > (while (and (consp exp) (not (eq '\, (car exp)))) > (push (inline--dont-quote (pop exp)) args)) > (setq args (nreverse args)) > - (if exp > - `(apply ,@args ,(inline--dont-quote exp)) > - args))) > + (if (null exp) > + args > + `(apply #',(car args) ,@(cdr args) ,(inline--dont-quote exp))))) > (_ exp))) > > (defun inline--do-leteval (var-exp &rest body) > Could we have this bug fixed in emacs-25? inline.el is new in 25.1 and broken. We should make sure 25.x have a usable version. Thoughts? Leo