Re: master e6161f6: * lisp/emacs-lisp/inline.el: Fix apply-conversion (bug#25280)

Re: master e6161f6: * lisp/emacs-lisp/inline.el: Fix apply-conversion (bug#25280)

[Leo Liu]

On 2016-12-27 17:44 +0000, Stefan Monnier wrote:
> branch: master
> commit e6161f648903d821865b9610b3b6aa0f82a5dcb7
> Author: Stefan Monnier <monnier@iro.umontreal.ca>
> Commit: Stefan Monnier <monnier@iro.umontreal.ca>
>
>     * lisp/emacs-lisp/inline.el: Fix apply-conversion (bug#25280)
>     
>     (inline--dont-quote): Quote the function with #' when passing it to `apply'.
> ---
>  lisp/emacs-lisp/inline.el |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/lisp/emacs-lisp/inline.el b/lisp/emacs-lisp/inline.el
> index 058c56c..5ceb0d9 100644
> --- a/lisp/emacs-lisp/inline.el
> +++ b/lisp/emacs-lisp/inline.el
> @@ -191,9 +191,9 @@ After VARS is handled, BODY is evaluated in the new environment."
>         (while (and (consp exp) (not (eq '\, (car exp))))
>           (push (inline--dont-quote (pop exp)) args))
>         (setq args (nreverse args))
> -       (if exp
> -           `(apply ,@args ,(inline--dont-quote exp))
> -         args)))
> +       (if (null exp)
> +           args
> +         `(apply #',(car args) ,@(cdr args) ,(inline--dont-quote exp)))))
>      (_ exp)))
>  
>  (defun inline--do-leteval (var-exp &rest body)
>

Could we have this bug fixed in emacs-25? inline.el is new in 25.1 and
broken. We should make sure 25.x have a usable version. Thoughts?

Leo

Re: master e6161f6: * lisp/emacs-lisp/inline.el: Fix apply-conversion (bug#25280)

[Stefan Monnier]

> Could we have this bug fixed in emacs-25? inline.el is new in 25.1 and
> broken.  We should make sure 25.x have a usable version.  Thoughts?

The patch applies to emacs-25 just fine, and I can't imagine how it
could break currently working code, so it can definitely go there.
But I'll let Eli and John decide if they want it: it's not very urgent.


        Stefan

Re: master e6161f6: * lisp/emacs-lisp/inline.el: Fix apply-conversion (bug#25280)

[John Wiegley]

>>>>> "SM" == Stefan Monnier <monnier@iro.umontreal.ca> writes:

SM> The patch applies to emacs-25 just fine, and I can't imagine how it could
SM> break currently working code, so it can definitely go there. But I'll let
SM> Eli and John decide if they want it: it's not very urgent.

If Eli's fine with it, it looks harmless enough to me.

-- 
John Wiegley                  GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com                          60E1 46C4 BD1A 7AC1 4BA2

Re: master e6161f6: * lisp/emacs-lisp/inline.el: Fix apply-conversion (bug#25280)

[Eli Zaretskii]

> From: John Wiegley <jwiegley@gmail.com>
> Date: Tue, 27 Dec 2016 20:43:42 -0800
> Cc: Leo Liu <sdl.web@gmail.com>, emacs-devel@gnu.org
> 
> >>>>> "SM" == Stefan Monnier <monnier@iro.umontreal.ca> writes:
> 
> SM> The patch applies to emacs-25 just fine, and I can't imagine how it could
> SM> break currently working code, so it can definitely go there. But I'll let
> SM> Eli and John decide if they want it: it's not very urgent.
> 
> If Eli's fine with it, it looks harmless enough to me.

No objections here.

Thanks.

Re: master e6161f6: * lisp/emacs-lisp/inline.el: Fix apply-conversion (bug#25280)

[Stefan Monnier]

Done, thanks,


        Stefan


>>>>> "Eli" == Eli Zaretskii <eliz@gnu.org> writes:

>> From: John Wiegley <jwiegley@gmail.com>
>> Date: Tue, 27 Dec 2016 20:43:42 -0800
>> Cc: Leo Liu <sdl.web@gmail.com>, emacs-devel@gnu.org
>> 
>> >>>>> "SM" == Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> 
SM> The patch applies to emacs-25 just fine, and I can't imagine how it could
SM> break currently working code, so it can definitely go there. But I'll let
SM> Eli and John decide if they want it: it's not very urgent.
>> 
>> If Eli's fine with it, it looks harmless enough to me.

> No objections here.

> Thanks.