Re: master 47e313e9805: Unbind 'C-M-i' in Text mode

[Eshel Yaron <me@eshelyaron.com>]

[-- Attachment #1: Type: text/plain, Size: 1668 bytes --]

Dmitry Gutov <dmitry@gutov.dev> writes:

> On 06/12/2023 09:53, Eshel Yaron wrote:
>> Hi Dmitry,
>> Dmitry Gutov <dmitry@gutov.dev> writes:
>>
>>>> +(defun ispell-completion-at-point ()
>>>> +  "Word completion function for use in `completion-at-point-functions'."
>>>> [...]
>>>> +         (list beg end (cdr all)
>>>> +               :annotation-function (lambda (_) " Dictionary word")
>>>
>>> I have to say that "Dictionary word" is not a great annotation: it's
>>> long, longer than most of the completions coming from that backend, so
>>> these words, repeated, constitute most of the text inside the
>>> Completions buffer. And it's the same string for all completions.
>> I see what you mean.  How do you feel about the following
>> alternatives?
>> - "Word"
>> - "Dict"
>> - "Spell"/"Ispell"
>> - "🕮"
>> - No annotation at all
>> - One of the above, and make it configurable
>
> My preference would be "no annotation at all", if we're talking about
> simple solutions.

Fine by me.  I'm attaching a simple patch that does that.

> The fourth option was a newspaper emoji?

Well, it's supposed to be a book, you get it with `C-x 8 RET book RET`.

> I think the more comprehensive approach here would be to implement
> support for `:company-kind` in the default UI, and then return `text'
> in that function.

I agree, that would be nice in general and help here too.  For this case
I was also thinking about using the common part-of-speech of each word
as its annotation (e.g. "n" for nouns, "v" for verbs...) but we don't
get that information from the spelling dictionary, unfortunately.


Here's that patch:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Remove-long-annotation-for-word-completion-candidate.patch --]
[-- Type: text/x-patch, Size: 837 bytes --]

From 5055fd663b3e82d752ae7aa3d0cad5d0ea4f87a6 Mon Sep 17 00:00:00 2001
From: Eshel Yaron <me@eshelyaron.com>
Date: Wed, 6 Dec 2023 14:41:56 +0100
Subject: [PATCH] ; Remove long annotation for word completion candidates

* lisp/textmodes/ispell.el (ispell-completion-at-point): Remove
':annotation-function' from return value.
---
 lisp/textmodes/ispell.el | 1 -
 1 file changed, 1 deletion(-)

diff --git a/lisp/textmodes/ispell.el b/lisp/textmodes/ispell.el
index 4c3b22281bd..2c387342026 100644
--- a/lisp/textmodes/ispell.el
+++ b/lisp/textmodes/ispell.el
@@ -3699,7 +3699,6 @@ ispell-completion-at-point
              (setcdr cur (cddr cur)))
            (setq cur (cdr cur)))
          (list beg end (cdr all)
-               :annotation-function (lambda (_) " Dictionary word")
                :exclusive 'no))))))
 
 
-- 
2.42.0