From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Stefan Newsgroups: gmane.emacs.devel Subject: Re: Slow access to files using UNC path Date: Wed, 08 Sep 2004 07:55:51 -0400 Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Message-ID: References: <68c73b1a04083122477869f5a@mail.gmail.com> <1094020967.1821.22.camel@localhost> <68c73b1a040907234950a01f97@mail.gmail.com> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1094644629 7977 80.91.224.253 (8 Sep 2004 11:57:09 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 8 Sep 2004 11:57:09 +0000 (UTC) Cc: KOBAYASHI Yasuhiro , Dhruva Krishnamurthy , Richard Stallman , Andre Spiegel , Emacs Devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Sep 08 13:56:58 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1C514M-0007DO-00 for ; Wed, 08 Sep 2004 13:56:58 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1C519d-00044l-0A for ged-emacs-devel@m.gmane.org; Wed, 08 Sep 2004 08:02:25 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1C518y-0003vq-LR for emacs-devel@gnu.org; Wed, 08 Sep 2004 08:01:44 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1C518t-0003t5-48 for emacs-devel@gnu.org; Wed, 08 Sep 2004 08:01:43 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1C518q-0003sf-UC for emacs-devel@gnu.org; Wed, 08 Sep 2004 08:01:38 -0400 Original-Received: from [206.47.199.166] (helo=simmts8-srv.bellnexxia.net) by monty-python.gnu.org with esmtp (Exim 4.34) id 1C513J-0004gj-OE; Wed, 08 Sep 2004 07:55:54 -0400 Original-Received: from empanada.home ([67.71.118.135]) by simmts8-srv.bellnexxia.net (InterMail vM.5.01.06.10 201-253-122-130-110-20040306) with ESMTP id <20040908115416.POFC1692.simmts8-srv.bellnexxia.net@empanada.home>; Wed, 8 Sep 2004 07:54:16 -0400 Original-Received: by empanada.home (Postfix, from userid 502) id 3A5042E0A3B; Wed, 8 Sep 2004 07:55:51 -0400 (EDT) Original-To: storm@cua.dk (Kim F. Storm) In-Reply-To: (Kim F. Storm's message of "Wed, 08 Sep 2004 10:18:14 +0200") User-Agent: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.3.50 (darwin) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:26884 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:26884 >> + (defvar vc-hostname-fs-path-re "\\`\\([\\/][\\/]\\|/net/\\|/afs/\\)" >> + "Regex variable used to avoid determining whether file is under vc-arch >> + or vc-mcvs. The default regexp prevents the determination of type of vc for >> + folders in UNC, net and afs. This speeds up opening of files by not trying to >> + determine whether file is under vc. This can be modified by user to match a >> + different path or paths") > In Emacs, a 'path' is something like load-path, and we never use the > term 'path' for a directory name or file name. Sorry 'bout that. > IMO, a better name would be something like `vc-ignore-file-re'. I disagree and I also disagree with the proposed docstring. We should document what the variable is meant for, not how it's used. It's meant for filenames which are interpreted by the system as hostnames. VC uses this variable to avoid looking up non-exitent host names. > folders in UNC, net and afs. This speeds up opening of files by not trying to > determine whether file is under vc. This makes it sound like it's always slow to determine whether a file is under VC or not, whereas it's normally not the case. It's only the case for those special cases which we try to eliminate with this variable: the case where the filename is used as a hostname and can thus lead to inordinate waits (timeouts and stuff like that). > BTW, I don't understand why this is specific for vc-arch and vc-mcvs ? It's not, but since only VC uses it as of now, it seems to make sense to only add it in vc-hooks.el. When some other package finds a use for such a thing, we can move it (and maybe change it along the way: it may turn out that something slightly different will be needed at that point). Stefan PS: As for the patch, it still misses the two other places (in the same file) where we do the same thing again.