From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Newsgroups: gmane.emacs.devel Subject: Re: Suspicious code in gnus-read-descriptions-file Date: Wed, 23 Mar 2005 07:53:32 -0500 Message-ID: References: <87eke71cnj.fsf@Jesper-Harders-Computer.local> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1111582943 19289 80.91.229.2 (23 Mar 2005 13:02:23 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 23 Mar 2005 13:02:23 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Mar 23 14:02:22 2005 Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DE5V0-0008MZ-3m for ged-emacs-devel@m.gmane.org; Wed, 23 Mar 2005 14:02:14 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DE5mU-0003ZS-VE for ged-emacs-devel@m.gmane.org; Wed, 23 Mar 2005 08:20:18 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DE5h2-0001Ac-GA for emacs-devel@gnu.org; Wed, 23 Mar 2005 08:14:40 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DE5fq-0000L9-Qc for emacs-devel@gnu.org; Wed, 23 Mar 2005 08:13:29 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DE5fL-0008O5-4d for emacs-devel@gnu.org; Wed, 23 Mar 2005 08:12:55 -0500 Original-Received: from [206.47.199.166] (helo=simmts8-srv.bellnexxia.net) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DE5Mb-0007p1-K2 for emacs-devel@gnu.org; Wed, 23 Mar 2005 07:53:33 -0500 Original-Received: from empanada.home ([70.49.83.30]) by simmts8-srv.bellnexxia.net (InterMail vM.5.01.06.10 201-253-122-130-110-20040306) with ESMTP id <20050323125332.OVBG1623.simmts8-srv.bellnexxia.net@empanada.home>; Wed, 23 Mar 2005 07:53:32 -0500 Original-Received: by empanada.home (Postfix, from userid 502) id 0D5AE48A124; Wed, 23 Mar 2005 07:53:32 -0500 (EST) Original-To: emacs-devel@gnu.org In-Reply-To: <87eke71cnj.fsf@Jesper-Harders-Computer.local> (Jesper Harder's message of "Wed, 23 Mar 2005 00:17:29 +0100") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (darwin) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org X-MailScanner-To: ged-emacs-devel@m.gmane.org Xref: news.gmane.org gmane.emacs.devel:35035 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:35035 >> (defun gnus-parse-active () >> "Parse active info in the nntp server buffer." >> - (save-excursion >> - (set-buffer nntp-server-buffer) >> + (with-current-buffer nntp-server-buffer >> (goto-char (point-min)) > Are you sure that not saving (and restoring) point in > nntp-server-buffer doesn't make a difference? (save-excursion (set-buffer FOO) BAR) saves point in the current buffer, not in FOO (unless FOO is already the current buffer before the set-buffer call). If you want to save point in FOO, then you need an extra save-excursion. > But if point /is/ changed, I've often found it pretty hard to be > absolutely sure if saving point is actually intended and required. There's indeed the possibility that the code is usually called with nntp-server-buffer already the current buffer and point in nntp-server-buffer needs to be saved. In that case I'd argue that the current code is buggy (either it should not have the set-buffer, or it should do the save-excursion after the set-buffer). Stefan