* Re: master d03677343e9: Pan during touch screen pinch gestures
[not found] ` <20231116033024.A8049C0C1B3@vcs2.savannah.gnu.org>
@ 2023-11-16 8:51 ` Eshel Yaron
2023-11-16 9:29 ` Po Lu
0 siblings, 1 reply; 3+ messages in thread
From: Eshel Yaron @ 2023-11-16 8:51 UTC (permalink / raw)
To: emacs-devel; +Cc: Po Lu
Hi Po Lu,
Po Lu via Mailing list for Emacs changes <emacs-diffs@gnu.org> writes:
> branch: master
> commit d03677343e9a54f76de7e3ac2db6e22df3fa4333
> Author: Po Lu <luangruo@yahoo.com>
> Commit: Po Lu <luangruo@yahoo.com>
>
> Pan during touch screen pinch gestures
Thanks for working on pinch gestures, that's really cool.
> * lisp/completion-preview.el (completion-preview-commands):
> Account text-conversion events preview commands as well.
I'm not sure I understand this change though,
> (defcustom completion-preview-commands '(self-insert-command
> insert-char
> delete-backward-char
> - backward-delete-char-untabify)
> + backward-delete-char-untabify
> + text-conversion)
> "List of commands that should trigger completion preview."
> :type '(repeat (function :tag "Command" :value self-insert-command))
> :version "30.1")
Is `text-conversion` a command? I can't find such a command or
function, even after rebuilding Emacs master following this commit.
OTOH I see that there's an event called `text-conversion`, that triggers
a command called `analyze-text-conversion`, so perhaps it's that command
that should go on `completion-preview-commands`?
Cheers,
Eshel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: master d03677343e9: Pan during touch screen pinch gestures
2023-11-16 8:51 ` master d03677343e9: Pan during touch screen pinch gestures Eshel Yaron
@ 2023-11-16 9:29 ` Po Lu
2023-11-16 9:45 ` Eshel Yaron
0 siblings, 1 reply; 3+ messages in thread
From: Po Lu @ 2023-11-16 9:29 UTC (permalink / raw)
To: Eshel Yaron; +Cc: emacs-devel
Eshel Yaron <me@eshelyaron.com> writes:
> Hi Po Lu,
>
> Po Lu via Mailing list for Emacs changes <emacs-diffs@gnu.org> writes:
>
>> branch: master
>> commit d03677343e9a54f76de7e3ac2db6e22df3fa4333
>> Author: Po Lu <luangruo@yahoo.com>
>> Commit: Po Lu <luangruo@yahoo.com>
>>
>> Pan during touch screen pinch gestures
>
> Thanks for working on pinch gestures, that's really cool.
>
>
>> * lisp/completion-preview.el (completion-preview-commands):
>> Account text-conversion events preview commands as well.
>
> I'm not sure I understand this change though,
>
>> (defcustom completion-preview-commands '(self-insert-command
>> insert-char
>> delete-backward-char
>> - backward-delete-char-untabify)
>> + backward-delete-char-untabify
>> + text-conversion)
>> "List of commands that should trigger completion preview."
>> :type '(repeat (function :tag "Command" :value self-insert-command))
>> :version "30.1")
>
> Is `text-conversion` a command? I can't find such a command or
> function, even after rebuilding Emacs master following this commit.
> OTOH I see that there's an event called `text-conversion`, that triggers
> a command called `analyze-text-conversion`, so perhaps it's that command
> that should go on `completion-preview-commands`?
Ah, sorry; that code should not have found its way into this commit. I
meant to commit this separately after testing it.
I'll correct this forthwith.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: master d03677343e9: Pan during touch screen pinch gestures
2023-11-16 9:29 ` Po Lu
@ 2023-11-16 9:45 ` Eshel Yaron
0 siblings, 0 replies; 3+ messages in thread
From: Eshel Yaron @ 2023-11-16 9:45 UTC (permalink / raw)
To: Po Lu; +Cc: emacs-devel
Po Lu <luangruo@yahoo.com> writes:
> Eshel Yaron <me@eshelyaron.com> writes:
>
>>> (defcustom completion-preview-commands '(self-insert-command
>>> insert-char
>>> delete-backward-char
>>> - backward-delete-char-untabify)
>>> + backward-delete-char-untabify
>>> + text-conversion)
>>> "List of commands that should trigger completion preview."
>>> :type '(repeat (function :tag "Command" :value self-insert-command))
>>> :version "30.1")
>>
>> Is `text-conversion` a command? I can't find such a command or
>> function, even after rebuilding Emacs master following this commit.
>> OTOH I see that there's an event called `text-conversion`, that triggers
>> a command called `analyze-text-conversion`, so perhaps it's that command
>> that should go on `completion-preview-commands`?
>
> Ah, sorry; that code should not have found its way into this commit. I
> meant to commit this separately after testing it.
>
> I'll correct this forthwith.
Thanks. FWIW I've now tested Completion Preview mode with the latest
Android build after substituting `text-conversion` with
`analyze-text-conversion` (as you did in the new commit), works nicely!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-11-16 9:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <170010542404.8395.4861984251472262512@vcs2.savannah.gnu.org>
[not found] ` <20231116033024.A8049C0C1B3@vcs2.savannah.gnu.org>
2023-11-16 8:51 ` master d03677343e9: Pan during touch screen pinch gestures Eshel Yaron
2023-11-16 9:29 ` Po Lu
2023-11-16 9:45 ` Eshel Yaron
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).