From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eshel Yaron Newsgroups: gmane.emacs.devel Subject: Re: master ff3f17ca3cd: choose-completion: Retain the suffix after completion boundary Date: Fri, 17 May 2024 10:56:06 +0200 Message-ID: References: <171522198055.22327.4428936546182324178@vcs2.savannah.gnu.org> <20240509023301.A25B3C1F9DE@vcs2.savannah.gnu.org> <7be03e7e-6b8a-420c-b0d8-a512d7917cf2@gutov.dev> <8f3b86fa-a7ee-4ef0-8953-944efb65f9df@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29143"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri May 17 10:57:00 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s7tOe-0007Nk-OX for ged-emacs-devel@m.gmane-mx.org; Fri, 17 May 2024 10:57:00 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s7tNy-0004E8-4g; Fri, 17 May 2024 04:56:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s7tNs-0004Dj-U8 for emacs-devel@gnu.org; Fri, 17 May 2024 04:56:13 -0400 Original-Received: from mail.eshelyaron.com ([107.175.124.16] helo=eshelyaron.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s7tNq-0002kL-67 for emacs-devel@gnu.org; Fri, 17 May 2024 04:56:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1715936168; bh=MCdReYSkPp5j2cWdPfSsiSkIsdWBpZFAqiGA6dteTf8=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=QwGKuSqCrwWxpRc5a/qlkUE8Zbu9bc+qCO5dQ8BqQcNaIc2IA4SUtd1W43hhP9hPW sVXtaMXAgE/+mq9kQjNs/8Hj7WAx2x+OQJ7KTnwMW/mtTFmlox0V2D2kCFWAztW3xN PXpxQ2OS+qi77Ntzj30jMGVgOA5eRrI/ZgBktPtP7QaDQF7YIuAnaHQiKHCXQpJcFc tiI4Yusf7Pjsi5ufxf0mBgVmojtPuODoj74HM7eErj1yAodi6vegh13LtUAiVTIjpz 9H3Rtt0LE1HGqxFk5hxOFBG4M2G4wbaKlRoF9iyoUncwGoo53KXB3nvM4MbfFT/INo 3IXBVL88fC/ug== In-Reply-To: (Eshel Yaron's message of "Mon, 13 May 2024 08:35:11 +0200") Received-SPF: pass client-ip=107.175.124.16; envelope-from=me@eshelyaron.com; helo=eshelyaron.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:319321 Archived-At: Hi Dmitry, Eshel Yaron writes: > Dmitry Gutov writes: > >> On 12/05/2024 15:38, Eshel Yaron wrote: >> >>> I can't seem to find this commit, though, is that on master? >> >> My bad, that push didn't go through. Now on master. > > Thanks, everything seems to work well now. I'm afraid there might be another regression, here's what I see: 1. emacs -Q 2. C-x C-f 3. C-a C-k to clear the minibuffer 4. Insert the path an Emacs checkout, e.g. "~/checkouts/emacs/" 5. Further insert "l/mi" 6. Hit ? to pop the completions list, which includes "lisp/minibuffer.el" and "leim/MISC-DIC/", among others. 7. Lean on M- to cycle between completion candidates. After the last fix, I see M- accumulate text after point in the minibuffer instead of replacing the part it previously inserted. Do you see that as well? Thanks, Eshel