From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eshel Yaron Newsgroups: gmane.emacs.devel Subject: Re: master ff3f17ca3cd: choose-completion: Retain the suffix after completion boundary Date: Sat, 18 May 2024 08:55:11 +0200 Message-ID: References: <171522198055.22327.4428936546182324178@vcs2.savannah.gnu.org> <20240509023301.A25B3C1F9DE@vcs2.savannah.gnu.org> <7be03e7e-6b8a-420c-b0d8-a512d7917cf2@gutov.dev> <8f3b86fa-a7ee-4ef0-8953-944efb65f9df@gutov.dev> <418c5f45-9f89-43dd-b8b8-00f0aab9192b@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21592"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat May 18 08:56:22 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s8DzR-0005Nl-GH for ged-emacs-devel@m.gmane-mx.org; Sat, 18 May 2024 08:56:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s8DyV-0005ED-8G; Sat, 18 May 2024 02:55:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s8DyP-0005E1-F2 for emacs-devel@gnu.org; Sat, 18 May 2024 02:55:17 -0400 Original-Received: from mail.eshelyaron.com ([107.175.124.16] helo=eshelyaron.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s8DyN-0001Rx-UL for emacs-devel@gnu.org; Sat, 18 May 2024 02:55:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1716015313; bh=pYByXV5I6kd2Xx+7wS4+pDj9DqL2T79zDQCaX/oU378=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=H1kq1HLoj5RDe3UHuNYXVqH3AHAqRmmmaxd5Fo0NBhb43kp9n2nochOiYvM72wcrO FAiK2bZhfVs+n8J9PpgDnn/EZpll+fRU04O9bhVLrU84n3oKG+KbONbfplIS8cJgw0 KPYKD574AgpHNLBcOHmjKIbpl2amRPX0l42notoqM/cWy26qJj7xq8yesgbeXV2qUZ eqxmskTUVrqH8PM3bTanb0Gmgm3V73rrbwNAPPMx4AWCQLj9GQWiJ+wPRqAQixn67p Hf1hOdeKqXtdxr3Is9aD3KpPDeoiD7FhnIOQUpiYkGhmDmD6Bma3GRpjPbxqfkQD6m aisFGP9T6/NPA== In-Reply-To: <418c5f45-9f89-43dd-b8b8-00f0aab9192b@gutov.dev> (Dmitry Gutov's message of "Sat, 18 May 2024 02:28:36 +0300") Received-SPF: pass client-ip=107.175.124.16; envelope-from=me@eshelyaron.com; helo=eshelyaron.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:319338 Archived-At: Dmitry Gutov writes: > Hi Eshel, > > On 17/05/2024 11:56, Eshel Yaron wrote: [...] >> I'm afraid there might be another regression, here's what I see: > > Thanks for keeping an eye out. > >> 1. emacs -Q >> 2. C-x C-f >> 3. C-a C-k to clear the minibuffer >> 4. Insert the path an Emacs checkout, e.g. "~/checkouts/emacs/" >> 5. Further insert "l/mi" >> 6. Hit ? to pop the completions list, which includes >> "lisp/minibuffer.el" and "leim/MISC-DIC/", among others. > > FWIW, I don't see "leim/MISC-DIC" among completions, even if I first > evaluate (setq completion-ignore-case t). Weird, perhaps you have read-file-name-completion-ignore-case set to nil and that takes effect rather than plain completion-ignore-case? > But the crux of the problem reproduces fine. Great. >> 7. Lean on M- to cycle between completion candidates. >> After the last fix, I see M- accumulate text after point in >> the >> minibuffer instead of replacing the part it previously inserted. Do you >> see that as well? > > Please take the attached patch for a spin. Nice, this seems to fix the regression at hand, and so far I'm not seeing any other issues. > It would be great if someone looked into writing integration tests for > this somehow. This is brittle stuff, and the variety of scenarios is > high enough. I agree. The default completion UI supports various interactions that can break in subtle ways, and that's without even configuring stuff. I'll try to code a couple of test cases when I have the time. Best, Eshel