From: Eshel Yaron <me@eshelyaron.com>
To: Dmitry Gutov <dmitry@gutov.dev>
Cc: emacs-devel@gnu.org
Subject: Re: master ff3f17ca3cd: choose-completion: Retain the suffix after completion boundary
Date: Sat, 18 May 2024 08:55:11 +0200 [thread overview]
Message-ID: <m1a5knmwxc.fsf@dazzs-mbp.kpn> (raw)
In-Reply-To: <418c5f45-9f89-43dd-b8b8-00f0aab9192b@gutov.dev> (Dmitry Gutov's message of "Sat, 18 May 2024 02:28:36 +0300")
Dmitry Gutov <dmitry@gutov.dev> writes:
> Hi Eshel,
>
> On 17/05/2024 11:56, Eshel Yaron wrote:
[...]
>> I'm afraid there might be another regression, here's what I see:
>
> Thanks for keeping an eye out.
>
>> 1. emacs -Q
>> 2. C-x C-f
>> 3. C-a C-k to clear the minibuffer
>> 4. Insert the path an Emacs checkout, e.g. "~/checkouts/emacs/"
>> 5. Further insert "l/mi"
>> 6. Hit ? to pop the completions list, which includes
>> "lisp/minibuffer.el" and "leim/MISC-DIC/", among others.
>
> FWIW, I don't see "leim/MISC-DIC" among completions, even if I first
> evaluate (setq completion-ignore-case t).
Weird, perhaps you have read-file-name-completion-ignore-case set to nil
and that takes effect rather than plain completion-ignore-case?
> But the crux of the problem reproduces fine.
Great.
>> 7. Lean on M-<down> to cycle between completion candidates.
>> After the last fix, I see M-<down> accumulate text after point in
>> the
>> minibuffer instead of replacing the part it previously inserted. Do you
>> see that as well?
>
> Please take the attached patch for a spin.
Nice, this seems to fix the regression at hand, and so far I'm not
seeing any other issues.
> It would be great if someone looked into writing integration tests for
> this somehow. This is brittle stuff, and the variety of scenarios is
> high enough.
I agree. The default completion UI supports various interactions that
can break in subtle ways, and that's without even configuring stuff.
I'll try to code a couple of test cases when I have the time.
Best,
Eshel
next prev parent reply other threads:[~2024-05-18 6:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <171522198055.22327.4428936546182324178@vcs2.savannah.gnu.org>
[not found] ` <20240509023301.A25B3C1F9DE@vcs2.savannah.gnu.org>
2024-05-10 16:10 ` master ff3f17ca3cd: choose-completion: Retain the suffix after completion boundary Eshel Yaron
2024-05-12 2:59 ` Dmitry Gutov
2024-05-12 12:38 ` Eshel Yaron
2024-05-12 16:03 ` Dmitry Gutov
2024-05-13 6:35 ` Eshel Yaron
2024-05-17 8:56 ` Eshel Yaron
2024-05-17 23:28 ` Dmitry Gutov
2024-05-18 6:55 ` Eshel Yaron [this message]
2024-05-18 13:33 ` Dmitry Gutov
2024-05-18 13:51 ` Eshel Yaron
2024-05-18 14:18 ` Dmitry Gutov
2024-05-29 10:05 ` Eshel Yaron
2024-05-29 10:37 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1a5knmwxc.fsf@dazzs-mbp.kpn \
--to=me@eshelyaron.com \
--cc=dmitry@gutov.dev \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).