From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: "Robert J. Chassell" Newsgroups: gmane.emacs.devel Subject: Re: buff-menu.el header line Date: Fri, 19 Nov 2004 15:31:31 +0000 (UTC) Message-ID: References: Reply-To: bob@rattlesnake.com NNTP-Posting-Host: deer.gmane.org X-Trace: sea.gmane.org 1100878337 21703 80.91.229.6 (19 Nov 2004 15:32:17 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 19 Nov 2004 15:32:17 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 19 16:32:12 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1CVAk6-0002hb-00 for ; Fri, 19 Nov 2004 16:32:10 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CVAt0-0002O5-1p for ged-emacs-devel@m.gmane.org; Fri, 19 Nov 2004 10:41:22 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1CVAse-0002HY-Nk for emacs-devel@gnu.org; Fri, 19 Nov 2004 10:41:00 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1CVAsd-0002Gn-O8 for emacs-devel@gnu.org; Fri, 19 Nov 2004 10:40:59 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CVAsd-0002GZ-JY for emacs-devel@gnu.org; Fri, 19 Nov 2004 10:40:59 -0500 Original-Received: from [69.168.110.189] (helo=rattlesnake.com) by monty-python.gnu.org with esmtp (Exim 4.34) id 1CVAjh-0001px-TW for emacs-devel@gnu.org; Fri, 19 Nov 2004 10:31:46 -0500 Original-Received: by rattlesnake.com via sendmail from stdin id (Debian Smail3.2.0.115) Fri, 19 Nov 2004 15:31:31 +0000 (UTC) Original-To: Stefan Monnier In-reply-to: (message from Stefan Monnier on Thu, 18 Nov 2004 16:23:16 -0500) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:30088 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:30088 Your fixes (revision 1.73) to patch list-buffers-noselect to fit in 80 columns work OK for me. As for the alignment patch, it works using today's CVS checkout of Fri, 2004 Nov 19 14:13 UTC, rebuilt with `bootfast'. However, the intangible text property still needs to be changed. Converting that line to (put-text-property 1 (point) 'fixed-pitch t)) looks OK to me. Here are the two patches to your revision 1.73: diff -rc2P /usr/local/src/emacs/lisp/buff-menu.el.\~1.73.\~ /usr/local/src/emacs/lisp/buff-menu.el *** /usr/local/src/emacs/lisp/buff-menu.el.~1.73.~ Fri Nov 19 14:13:41 2004 --- /usr/local/src/emacs/lisp/buff-menu.el Fri Nov 19 15:05:29 2004 *************** *** 654,658 **** (Buffer-menu-make-sort-button "File" 5) "\n")) list desired-point) ! (when Buffer-menu-use-header-line (let ((pos 0)) ;; Turn spaces in the header into stretch specs so they work --- 654,658 ---- (Buffer-menu-make-sort-button "File" 5) "\n")) list desired-point) ! ;; (when Buffer-menu-use-header-line (let ((pos 0)) ;; Turn spaces in the header into stretch specs so they work *************** *** 663,667 **** ;; Assume fixed-size chars (list 'space :align-to (1- pos)) ! header)))) (with-current-buffer (get-buffer-create "*Buffer List*") (setq buffer-read-only nil) --- 663,667 ---- ;; Assume fixed-size chars (list 'space :align-to (1- pos)) ! header))) ;; ) (with-current-buffer (get-buffer-create "*Buffer List*") (setq buffer-read-only nil) *************** *** 672,676 **** (insert (Buffer-menu-buffer+size "------" "----")) (insert " ----" mode-end "----\n") ! (put-text-property 1 (point) 'intangible t)) (if buffer-list (setq list buffer-list) --- 672,676 ---- (insert (Buffer-menu-buffer+size "------" "----")) (insert " ----" mode-end "----\n") ! (put-text-property 1 (point) 'fixed-pitch t)) (if buffer-list (setq list buffer-list) Diff finished. Fri Nov 19 15:10:31 2004 Another bug: when Buffer-menu-use-header-line is set to nil, even though a keybinding appears as an echo area `tip' when you move the mouse over a header line position, Buffer-menu-mouse-select fails. Buffer-menu-mouse-select should succeed. Stephan Stahl suggested sort commands that could be attached to keybindings. This makes sense. This could be done after the release. For example: C-c C-s C-b for sort-buffername C-c C-s C-s for sort-size C-c C-s C-m for sort-mode C-c C-s C-f for sort-file C-c C-s C-u for sort-unsorted -- Robert J. Chassell bob@rattlesnake.com GnuPG Key ID: 004B4AC8 http://www.rattlesnake.com http://www.teak.cc