unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Juri Linkov <juri@jurta.org>, emacs-devel@gnu.org
Subject: Re: ChangeLog fontifications
Date: 12 May 2004 08:55:18 -0400	[thread overview]
Message-ID: <m18yfxn76f.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <u3c662o23.fsf@gnu.org>

>> > It's not the highlighting that's incorrect, it's the syntax.
>> > Actually I have extended my font-lock regexes to recognize the above and
>> > mark it in font-lock-warning-face.
>> > I also have a highlight pattern to try and recognize when the past tense is
>> > used ;-)
>> It seems your rules are useful to be added to add-log.el to help the
>> developers to write more correct entries in ChangeLog files.
> Seconded.

Problem is, I expect many people use change-log-mode in files where they do
not follow all the rules and they'd be annoyed by such changes.
And of course the "detect past tense" thingy is english-only, so it's also
inappropriate in general.


        Stefan


+    ;; Style warnings.
+    ("[ \t]+$" (0 'trailing-whitespace t))
+    ("^ +" (0 'trailing-whitespace t))
+    ;; Use
+    ;;   * foo.el (bla, bli)
+    ;;   (blo, blu): Toto.
+    ;; Rather than
+    ;;   * foo.el (bla, bli,
+    ;;   blo, blu): Toto.
+    ("^\\s-+\\(\\* .*\\)?([^\n)]*,\\s-*$" (0 font-lock-warning-face t))
+    ;; Don't cut a sentence right after the first word (better to move
+    ;; the sentence on the next line, then).
+    ("[.:]\\s-+\\(\\sw+\\)\\s-*$" (1 font-lock-warning-face t))
+    ;; Change Log entries should use present tense.
+    ("):[ \t\n]*[[:alpha:]]+\\(ed\\)\\>" (1 font-lock-warning-face t))
+    ;; Change log entries start with a capital letter.
+    ("): [a-z]" (0 font-lock-warning-face t)))

  reply	other threads:[~2004-05-12 12:55 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-11 17:15 ChangeLog fontifications Sam Steingold
2004-05-11 18:03 ` Juri Linkov
2004-05-11 22:54   ` Sam Steingold
2004-05-11 23:02     ` Miles Bader
2004-05-12  8:33       ` Werner LEMBERG
2004-05-12 10:10         ` Miles Bader
2004-05-12 12:36           ` Eli Zaretskii
2004-05-13 17:22           ` Sam Steingold
2004-05-14 21:01             ` Richard Stallman
2004-05-11 23:26     ` Stefan Monnier
2004-05-12  0:08       ` Juri Linkov
2004-05-12  5:48         ` Eli Zaretskii
2004-05-12 12:55           ` Stefan Monnier [this message]
  -- strict thread matches above, loose matches on Subject: below --
2004-05-13 18:50 Bruno Haible
2004-05-13 19:26 ` Miles Bader
2004-05-13 19:43   ` Bruno Haible
2004-05-13 20:38     ` Miles Bader
2004-05-13 21:12       ` Sam Steingold
2004-05-13 21:15         ` Miles Bader
2004-05-13 20:13 ` Alan Shutko
2004-05-13 20:42   ` Miles Bader
2004-05-13 21:37   ` Werner LEMBERG
2004-05-13 21:56     ` Miles Bader
2004-05-13 22:25       ` Stefan Monnier
2004-05-14  3:00       ` Karl Eichwalder
2004-05-14  4:24         ` Miles Bader
2004-05-14 13:56         ` Robert J. Chassell
2004-05-14  6:24       ` Werner LEMBERG
2004-05-14  6:36         ` Werner LEMBERG
2004-05-14 15:31       ` Sam Steingold
2004-05-14 21:02 ` Richard Stallman
2004-05-16 15:14   ` Bruno Haible
2004-05-16 16:52     ` Eli Zaretskii
2004-05-16 20:52       ` Miles Bader
2004-05-17 22:57     ` Richard Stallman
2004-05-18  5:02       ` Karl Eichwalder
2004-05-19  1:32         ` Miles Bader
2004-05-19 13:08           ` Sam Steingold
2004-05-19 13:22             ` Miles Bader
2004-05-19 14:59               ` Stefan Monnier
2004-05-19 13:45         ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m18yfxn76f.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=juri@jurta.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).