unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Daniel Martín" <mardani29@yahoo.es>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Boruch Baum <boruch_baum@gmx.com>,
	Emacs-Devel List <emacs-devel@gnu.org>
Subject: Re: Tab advance for tabulated-list-mode [CODE ATTACHED]
Date: Sun, 17 Jan 2021 17:00:05 +0100	[thread overview]
Message-ID: <m18s8rk0ze.fsf@yahoo.es> (raw)
In-Reply-To: <jwvturfk2x4.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Sun, 17 Jan 2021 10:20:26 -0500")

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>>>
>>> (define-key tabulated-list-mode-map "\t"              'tabulated-list-tab-forward)
>>> (define-key tabulated-list-mode-map (kbd "<backtab>") 'tabulated-list-tab-backward)
>>
>>
>> How would this work when the tabulated list has one or more buttons?
>
> Presumably the major mode will be derived from `tabulated-list-mode` and
> the keymap will have `tabulated-list-mode-map` as its parent, so any
> specific local bindings (or local buttons) should take precedence, so
> the above patch shouldn't cause a regression.

I didn't mean a regression, but a change in behavior.  I've installed
the patch locally, and pressing TAB in *Packages* now goes from column
to column.  Before the patch, it went from package to package.  We can
either:

a) Accept the new behavior, as it is more intuitive in my opinion.
b) Override the binding in package.el, to preserve the original
behavior.

(The same may happen to other packages that inherit from
tabulated-list-mode.)

I'm in favor of the change.  If it's documented well in NEWS, it
shouldn't cause much trouble if packages need to adapt to it.



  reply	other threads:[~2021-01-17 16:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-17  7:17 Tab advance for tabulated-list-mode [CODE ATTACHED] Boruch Baum
2021-01-17 11:05 ` Daniel Martín
2021-01-17 12:00   ` Boruch Baum
2021-01-17 15:20   ` Stefan Monnier
2021-01-17 16:00     ` Daniel Martín [this message]
2021-01-17 18:58       ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m18s8rk0ze.fsf@yahoo.es \
    --to=mardani29@yahoo.es \
    --cc=boruch_baum@gmx.com \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).