From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Nicolas P. Rougier (inria)" Newsgroups: gmane.emacs.devel Subject: Re: ELPA: New package: svg-lib Date: Mon, 27 Sep 2021 22:47:05 +0200 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22292"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.6.6; emacs 27.2 Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Sep 27 22:50:08 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mUxZf-0005Yp-3B for ged-emacs-devel@m.gmane-mx.org; Mon, 27 Sep 2021 22:50:07 +0200 Original-Received: from localhost ([::1]:52896 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mUxZe-0002yU-27 for ged-emacs-devel@m.gmane-mx.org; Mon, 27 Sep 2021 16:50:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45506) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mUxYy-0002HI-GG for emacs-devel@gnu.org; Mon, 27 Sep 2021 16:49:24 -0400 Original-Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:22767) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mUxYw-0007xS-Ej for emacs-devel@gnu.org; Mon, 27 Sep 2021 16:49:24 -0400 IronPort-HdrOrdr: =?us-ascii?q?A9a23=3AdFIXYKCBoOcScLTlHemc55DYdb4zR+YMi2TD?= =?us-ascii?q?GXofdfUzSL39qynOpoV/6faaslcssR0b9OyoGK7FWn/E8I4w/I95B9eftWrdyQ?= =?us-ascii?q?mVxeNZnOjfKlTbckXDH6xmvpuIGJIRNDSfNzRHpPrh7BL9G9gtx8TvysqVuds?= =?us-ascii?q?=3D?= X-IronPort-AV: E=Sophos;i="5.84,326,1620684000"; d="scan'208";a="394177111" Original-Received: from 91-160-114-139.subs.proxad.net (HELO M-E7-NPR) ([91.160.114.139]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Sep 2021 22:49:19 +0200 In-reply-to: Received-SPF: pass client-ip=192.134.164.104; envelope-from=nicolas.rougier@inria.fr; helo=mail3-relais-sop.national.inria.fr X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:275618 Archived-At: Thanks for the report. I've fixed most of them and let you know=20 when everythign is fixed. May I ask how you get such detailed report on the byte=20 compilation? Mine output is much smaller and do not report=20 everything (I simply used the byte-compile-file). Nicolas Stefan Monnier writes: > Nicolas P. Rougier (inria) [2021-09-27 15:49:16] wrote: >> generating various SVG tags, progress bars, progress pies &=20 >> icons that fits >> nicely in a text buffer. >> >> The library is hosted at https://github.com/rougier/svg-lib and=20 >> the README >> displays what it looks like. > > Looks good to me. Before I add it, tho: > > - Please make sure (from now on) that contributors have signed=20 > paperwork > (or that the sum of their contributions stays within the=20 > "trivial" > limit) before you accept their patches. > > - The svg-lib-demo.el lacks a `;; Copyright (C) 2021 Free=20 > Software Foundation, Inc.` > > Also, see below the warnings I got when trying to byte-compile=20 > it. > And while I'm here I'd recommend allowing the users to *load*=20 > svg-lib.el > even if (not (image-type-available-p 'svg)) and only signal an=20 > error > when they actually use the library. > > > Stefan > > > % make packages/svg-lib > emacs --batch -Q -l admin/elpa-admin.el \ > -f elpaa-batch-pkg-spec-make-dependencies .pkg-descs.mk > Generating description file packages/svg-lib/svg-lib-pkg.el > emacs --batch -l admin/elpa-admin.el=20 > \ > -f elpaa-batch-generate-autoloads=20 > packages/svg-lib/svg-lib-autoloads.el > INFO Scraping files for svg-lib-autoloads.el...=20 > INFO Scraping files for svg-lib-autoloads.el...done > Byte compiling packages/svg-lib/svg-lib-demo.el > Unable to activate package =E2=80=98tuareg=E2=80=99. > Required package =E2=80=98caml-3.12.0.1=E2=80=99 is unavailable > Unable to activate package =E2=80=98use-package=E2=80=99. > Required package =E2=80=98bind-key-2.4=E2=80=99 is unavailable > Unable to activate package =E2=80=98modus-vivendi-theme=E2=80=99. > Required package =E2=80=98modus-themes-1.2.4=E2=80=99 is unavailable > Unable to activate package =E2=80=98modus-operandi-theme=E2=80=99. > Required package =E2=80=98modus-themes-1.2.4=E2=80=99 is unavailable > > In toplevel form: > packages/svg-lib/svg-lib-demo.el:41:3:Warning: reference to free=20 > variable > =E2=80=98GNU=E2=80=99 > packages/svg-lib/svg-lib-demo.el:41:7:Warning: reference to free=20 > variable > =E2=80=98Emacs=E2=80=99 > Byte compiling packages/svg-lib/svg-lib.el > Unable to activate package =E2=80=98tuareg=E2=80=99. > Required package =E2=80=98caml-3.12.0.1=E2=80=99 is unavailable > Unable to activate package =E2=80=98use-package=E2=80=99. > Required package =E2=80=98bind-key-2.4=E2=80=99 is unavailable > Unable to activate package =E2=80=98modus-vivendi-theme=E2=80=99. > Required package =E2=80=98modus-themes-1.2.4=E2=80=99 is unavailable > Unable to activate package =E2=80=98modus-operandi-theme=E2=80=99. > Required package =E2=80=98modus-themes-1.2.4=E2=80=99 is unavailable > > In toplevel form: > packages/svg-lib/svg-lib.el:91:1:Warning: defcustom for > =E2=80=98svg-lib-icon-collections=E2=80=99 provides redundant :group > packages/svg-lib/svg-lib.el:115:1:Warning: defcustom for=20 > =E2=80=98svg-lib-icons-dir=E2=80=99 > provides redundant :group > packages/svg-lib/svg-lib.el:152:1:Warning: defcustom for > =E2=80=98svg-lib-style-default=E2=80=99 provides redundant :group > > In svg-lib-style: > packages/svg-lib/svg-lib.el:177:44:Warning: Unused lexical=20 > variable `value' > > In svg-lib-tag: > packages/svg-lib/svg-lib.el:214:40:Warning: Unused lexical=20 > variable `width' > packages/svg-lib/svg-lib.el:217:40:Warning: Unused lexical=20 > variable `scale' > packages/svg-lib/svg-lib.el:229:33:Warning: Unused lexical=20 > variable > `tag-char-height' > > In svg-lib-progress-pie: > packages/svg-lib/svg-lib.el:267:40:Warning: Unused lexical=20 > variable `width' > packages/svg-lib/svg-lib.el:269:40:Warning: Unused lexical=20 > variable `scale' > packages/svg-lib/svg-lib.el:274:40:Warning: Unused lexical=20 > variable > `font-weight' > packages/svg-lib/svg-lib.el:280:66:Warning: Unused lexical=20 > variable `ascent' > packages/svg-lib/svg-lib.el:281:33:Warning: Unused lexical=20 > variable > `tag-char-width' > packages/svg-lib/svg-lib.el:282:33:Warning: Unused lexical=20 > variable > `tag-char-height' > packages/svg-lib/svg-lib.el:289:27:Warning: Unused lexical=20 > variable `tag-x' > packages/svg-lib/svg-lib.el:299:33:Warning: reference to free=20 > variable =E2=80=98pi=E2=80=99 > > In svg-lib-progress-bar: > packages/svg-lib/svg-lib.el:340:40:Warning: Unused lexical=20 > variable `scale' > packages/svg-lib/svg-lib.el:345:40:Warning: Unused lexical=20 > variable > `font-weight' > packages/svg-lib/svg-lib.el:351:66:Warning: Unused lexical=20 > variable `ascent' > packages/svg-lib/svg-lib.el:352:33:Warning: Unused lexical=20 > variable > `tag-char-width' > packages/svg-lib/svg-lib.el:353:33:Warning: Unused lexical=20 > variable > `tag-char-height' > > In svg-lib-icon: > packages/svg-lib/svg-lib.el:427:40:Warning: Unused lexical=20 > variable > `font-size' > packages/svg-lib/svg-lib.el:428:40:Warning: Unused lexical=20 > variable > `font-family' > packages/svg-lib/svg-lib.el:429:40:Warning: Unused lexical=20 > variable > `font-weight' > packages/svg-lib/svg-lib.el:444:20:Warning: string-to-number=20 > quoted with ' > rather than with #' > packages/svg-lib/svg-lib.el:471:35:Warning: Unused lexical=20 > variable `fill' > > In svg-lib-button: > packages/svg-lib/svg-lib.el:508:28:Warning: Unused lexical=20 > variable > `box-width' > packages/svg-lib/svg-lib.el:509:36:Warning: Unused lexical=20 > variable > `box-height' > packages/svg-lib/svg-lib.el:515:33:Warning: Unused lexical=20 > variable > `tag-char-height' > packages/svg-lib/svg-lib.el:557:35:Warning: Unused lexical=20 > variable `fill' > > In end of data: > packages/svg-lib/svg-lib.el:167:18:Warning: the function=20 > =E2=80=98color-rgb-to-hex=E2=80=99 is > not known to be defined.