unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Robert J. Chassell" <bob@rattlesnake.com>
Subject: Re: silly face function names
Date: Fri, 20 Dec 2002 13:22:47 +0000 (UTC)	[thread overview]
Message-ID: <m18PN71-000IeAC@localhost> (raw)
In-Reply-To: <5xd6nx0xne.fsf@kfs2.cua.dk> (storm@cua.dk)

   Miles Bader <miles@lsi.nec.co.jp> writes:

   > There are a number of face manipulation functions in faces.el of the
   > form `set-face-FOO-p'.  I think such names are misleading, ...

Yes, they are misleading.

As storm@cua.dk (Kim F. Storm) says

   The names are badly chosen (having both 'set-' and '-p' is confusing),
   but if you read the names like this, it does make sense:

           set-face - FOO-p

which is true.  Kim then goes on to say

   IMHO, there is an abundance of silly functions and commands in
   faces.el; I don't see any reason to rename a few of them (which are
   rarely used anyway - I found only 5 places total).  

But even a few silly names should be fixed.  Our long term goal should
be code that is clear and meaningful, not misleading or silly.  That
means cleaning up previous silly messes.

As ESR said after he cleaned up a large number of messes for the shift
from GNU Emacs version 18 to version 19, "that was an Augean Stables."

-- 
    Robert J. Chassell                         Rattlesnake Enterprises
    http://www.rattlesnake.com                  GnuPG Key ID: 004B4AC8
    http://www.teak.cc                             bob@rattlesnake.com

  parent reply	other threads:[~2002-12-20 13:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-12-20  7:43 silly face function names Miles Bader
2002-12-20 10:53 ` Kim F. Storm
2002-12-20 10:08   ` Miles Bader
2002-12-20 11:28     ` Kim F. Storm
2002-12-20 13:22   ` Robert J. Chassell [this message]
2002-12-20 14:46     ` Kim F. Storm
2003-01-10 23:21 ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m18PN71-000IeAC@localhost \
    --to=bob@rattlesnake.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).