From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: make-indirect-buffer Date: 12 Apr 2004 17:01:09 -0400 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: References: <200404120519.i3C5Jrn21195@raven.dms.auburn.edu> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1081803838 29677 80.91.224.253 (12 Apr 2004 21:03:58 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 12 Apr 2004 21:03:58 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Mon Apr 12 23:03:47 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1BD8ap-0007u0-00 for ; Mon, 12 Apr 2004 23:03:47 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1BD8ap-0005JG-00 for ; Mon, 12 Apr 2004 23:03:47 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.30) id 1BD7cG-0003ZR-18 for emacs-devel@quimby.gnus.org; Mon, 12 Apr 2004 16:01:12 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30) id 1BD7cA-0003Yb-6O for emacs-devel@gnu.org; Mon, 12 Apr 2004 16:01:06 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30) id 1BD7c8-0003Vt-F2 for emacs-devel@gnu.org; Mon, 12 Apr 2004 16:01:04 -0400 Original-Received: from [206.47.199.141] (helo=simmts12-srv.bellnexxia.net) by monty-python.gnu.org with esmtp (Exim 4.30) id 1BD7c8-0003Vj-0S for emacs-devel@gnu.org; Mon, 12 Apr 2004 16:01:04 -0400 Original-Received: from empanada.local ([67.71.32.91]) by simmts12-srv.bellnexxia.net (InterMail vM.5.01.06.05 201-253-122-130-105-20030824) with ESMTP id <20040412210110.DCND25455.simmts12-srv.bellnexxia.net@empanada.local>; Mon, 12 Apr 2004 17:01:10 -0400 Original-Received: by empanada.local (Postfix, from userid 502) id F403415715C; Mon, 12 Apr 2004 17:01:09 -0400 (EDT) Original-To: Luc Teirlinck In-Reply-To: <200404120519.i3C5Jrn21195@raven.dms.auburn.edu> Original-Lines: 38 User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.4 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:21535 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:21535 > *************** > *** 536,544 **** > if (!NILP (buf)) > error ("Buffer name `%s' is in use", SDATA (name)); > base_buffer = Fget_buffer (base_buffer); > ! if (NILP (base_buffer)) > ! error ("No such buffer: `%s'", SDATA (name)); > if (SCHARS (name) == 0) > error ("Empty string for buffer name is not allowed"); > --- 536,547 ---- > if (!NILP (buf)) > error ("Buffer name `%s' is in use", SDATA (name)); > + if (NILP (Fget_buffer (base_buffer))) > + error ("No such buffer: `%s'", SDATA (base_buffer)); > + > base_buffer = Fget_buffer (base_buffer); > ! if (NILP (XBUFFER (base_buffer)->name)) > ! error ("Base buffer has been killed"); > if (SCHARS (name) == 0) > error ("Empty string for buffer name is not allowed"); The basic idea looks fine, but the above code calls Fget_buffer twice for no reason. It seems the following code would work as well: base_buffer = Fget_buffer (base_buffer); if (NILP (base_buffer)) /* We assume that (get-buffer foo)==nil implies STRINGP (foo). Is that true? --Stef */ error ("No such buffer: `%s'", SDATA (base_buffer)); if (NILP (XBUFFER (base_buffer)->name)) error ("Base buffer has been killed"); -- Stefan