From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eshel Yaron Newsgroups: gmane.emacs.devel Subject: Re: Word completion in text modes Date: Sat, 18 Nov 2023 20:03:45 +0100 Message-ID: References: <83h6ljme0j.fsf@gnu.org> <83edgnmaqw.fsf@gnu.org> <837cmfm30o.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30652"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Nov 18 20:04:46 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r4QcY-0007iW-0Z for ged-emacs-devel@m.gmane-mx.org; Sat, 18 Nov 2023 20:04:46 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r4Qbg-0006ze-FF; Sat, 18 Nov 2023 14:03:52 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r4Qbf-0006zW-1q for emacs-devel@gnu.org; Sat, 18 Nov 2023 14:03:51 -0500 Original-Received: from mail.eshelyaron.com ([107.175.124.16] helo=eshelyaron.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r4Qbd-00047I-IM; Sat, 18 Nov 2023 14:03:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1700334228; bh=v1hPGhTfmYsOmKMrCOyCPvP1UsBq3eeNkiHxyFqe9AY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=rZYSxDCRWTKUePfdjw1lKI9QVyB0kEvf3HU+RMXb40iuVDRbISI2b1BU23vfK6ae+ aIARAaf5nGedIpDecPJqKsVd92AcCjEi+ozeKmGfPuDjmT7zd/4SU4HeuKJaKrDYqK xE/Ez9OdGRkfLfxnluI5ugkQMzlDEnE3RKp7Zb3ejCivXBzy/8jlVgRojGvP8YlK// 869pI3rpiisIpHLW/CD3G4EnyRJUFBYq21Al3NnbCNfvYqXZmXkBbacBvRsNtx82Xq Ej+nyNKmoH5TVnVrXLqSXIq4XKOcLJqX7yyP56ifQaDOd7vmUudxkvRxHls4xKRivL ZgRRD+rWMnpOw== In-Reply-To: <837cmfm30o.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 18 Nov 2023 18:37:11 +0200") Received-SPF: pass client-ip=107.175.124.16; envelope-from=me@eshelyaron.com; helo=eshelyaron.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:312924 Archived-At: Eli Zaretskii writes: >> From: Eshel Yaron >> Cc: emacs-devel@gnu.org >> Date: Sat, 18 Nov 2023 16:53:28 +0100 >> >> `ispell-complete-word` reuses the spell correction UI of `ispell-word` >> for word completion. That's something that I wouldn't necessarily try >> to port over to `completion-at-point` for compatibility sake, as we now >> have various proper completion (not spell correction) interfaces that >> were not available when `ispell-complete-word` came about. > > If we don't preserve that UI, we will be making an incompatible > change, which from my POV is undesirable. It doesn't matter whether > we like or dislike the ispell UI for this: compatibility means just > that. We could make the old UI an opt-in behavior, but tossing it > altogether is not something I'd welcome. I think we mostly agree then, because I didn't suggest tossing the old UI anywhere. To opt-in to the old behavior, you'd say: (keymap-set text-mode-map "C-M-i" #'ispell-complete-word) That seems to me like a simple enough tip for users that we could appear in a NEWS entry. Does that sound reasonable? >> Either way it'd be compatible in the sense that you get the same >> completions, and `ispell-complete-word` wouldn't go anywhere so >> users could rebind it if they really want to. > > That is not compatibility in my book, sorry. We should actually offer > a very similar or identical UI. Yes, I wonder just wonder how should we offer that UI. Doesn't keeping the command around for users to make use of cover it? Or do you mean there should be some user option for selecting the word completion UI?