From: Stefan <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: Another bug with the macro counter
Date: Sat, 30 Oct 2004 00:06:11 -0400 [thread overview]
Message-ID: <m14qkcyhpj.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <200410300327.i9U3RWW02355@raven.dms.auburn.edu> (Luc Teirlinck's message of "Fri, 29 Oct 2004 22:27:32 -0500 (CDT)")
> ***************
> *** 865,873 ****
> (if (and (integerp value)
> (or (not (memq this-command '(eval-last-sexp eval-print-last-sexp)))
> (eq this-command last-command)
> ! (and (boundp 'edebug-active) edebug-active)))
> (let ((char-string
> ! (if (or (and (boundp 'edebug-active) edebug-active)
> (memq this-command '(eval-last-sexp eval-print-last-sexp)))
> (prin1-char value))))
> (if char-string
> --- 865,874 ----
> (if (and (integerp value)
> (or (not (memq this-command '(eval-last-sexp eval-print-last-sexp)))
> (eq this-command last-command)
> ! (and (boundp 'edebug-active) (with-no-warnings edebug-active))))
> (let ((char-string
> ! (if (or (and (boundp 'edebug-active)
> ! (with-no-warnings edebug-active))
> (memq this-command '(eval-last-sexp eval-print-last-sexp)))
> (prin1-char value))))
> (if char-string
I believe replacing (and (boundp 'foo) foo) with (if (boundp 'foo) foo)
is a better choice because it removes the warning wihtout cluttering the
code and without introducing compatibility problems with older Emacsen.
Stefan
next prev parent reply other threads:[~2004-10-30 4:06 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-21 1:07 Another bug with the macro counter Luc Teirlinck
2004-10-30 2:38 ` Luc Teirlinck
2004-10-30 3:27 ` Luc Teirlinck
2004-10-30 4:06 ` Stefan [this message]
2004-10-30 14:19 ` Luc Teirlinck
2004-10-30 16:12 ` Stefan
2004-10-30 18:06 ` David Kastrup
2004-10-30 23:13 ` Luc Teirlinck
2004-10-31 0:09 ` Stefan
2004-10-31 7:43 ` David Kastrup
2004-10-31 13:30 ` Andreas Schwab
2004-10-31 17:05 ` Stefan
2004-10-31 18:36 ` David Kastrup
2004-10-31 18:52 ` Luc Teirlinck
2004-10-30 14:24 ` Luc Teirlinck
2004-10-30 14:51 ` Luc Teirlinck
2004-10-30 21:57 ` Kim F. Storm
2004-10-30 22:04 ` Luc Teirlinck
2004-10-30 22:09 ` Luc Teirlinck
2004-10-30 22:43 ` Kim F. Storm
2004-10-31 21:01 ` Luc Teirlinck
2004-10-31 23:23 ` Kim F. Storm
2004-11-01 7:24 ` Richard Stallman
2004-10-31 9:42 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m14qkcyhpj.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).