From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Nicolas P. Rougier (inria)" Newsgroups: gmane.emacs.devel Subject: Re: ELPA: New package: minibuffer-header Date: Sun, 07 Aug 2022 10:10:06 +0200 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15142"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.8.7; emacs 28.1 Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Aug 07 10:14:09 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oKbQH-0003mo-4w for ged-emacs-devel@m.gmane-mx.org; Sun, 07 Aug 2022 10:14:09 +0200 Original-Received: from localhost ([::1]:55786 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oKbQF-0005rs-KZ for ged-emacs-devel@m.gmane-mx.org; Sun, 07 Aug 2022 04:14:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37270) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oKbO7-00053C-F0 for emacs-devel@gnu.org; Sun, 07 Aug 2022 04:11:55 -0400 Original-Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:30314) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oKbNz-0002Jy-Fs for emacs-devel@gnu.org; Sun, 07 Aug 2022 04:11:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=references:from:to:cc:subject:date:in-reply-to: message-id:mime-version:content-transfer-encoding; bh=DBaFBRD0fVFkph+DcvSyGV5mhfonR8PClwE2dJwPxFk=; b=CgMcipCxiLQRQSt5qj2NEUWIN6pGzapaChOHoYiBgckeOcvZoYeF2qNx GDFVc1pZbZDiy3zIy/bdgKtl5U3MWpDZTSJDCX6pHQYCHfRIVrCcNvJNI 2bNKBU/rnA3G87vRCwzJl46LxhiA01O7l0dly2ahMH2dIzag6+ixXJZMh U=; Authentication-Results: mail3-relais-sop.national.inria.fr; dkim=none (message not signed) header.i=none; spf=SoftFail smtp.mailfrom=nicolas.rougier@inria.fr; dmarc=fail (p=none dis=none) d=inria.fr X-IronPort-AV: E=Sophos;i="5.93,219,1654552800"; d="scan'208";a="20915162" Original-Received: from 91-160-114-139.subs.proxad.net (HELO M-E7-NPR) ([91.160.114.139]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Aug 2022 10:11:45 +0200 In-reply-to: Received-SPF: pass client-ip=192.134.164.104; envelope-from=nicolas.rougier@inria.fr; helo=mail3-relais-sop.national.inria.fr X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:293186 Archived-At: Stefan Monnier [2022-08-06 at 18:03] wrote: > + ;; FIXME: Thje arglist looks wrong. It's what I would expect=20 > for > + ;; an `:around' advice, but not for an `:override' advice,=20 > which > + ;; does not receive the `orig-fun'. > "This advice is used to override the original message=20 > function" Thanks, this helps me to identify a nasty bug when overriding the=20 message function. I applied all the modifications. Nicolas --=20 Nicolas P. Rougier =E2=80=94=E2=80=94 Research Director Institute of Neurodegenerative Diseases Bordeaux =E2=80=94=E2=80=94 www.labri.fr/perso/nrougier