From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eshel Yaron Newsgroups: gmane.emacs.devel Subject: Re: master 6b7ff60a5e7: Highlight the suffix in *Completions* buffer in 'basic' style too Date: Mon, 01 Jul 2024 10:58:20 +0200 Message-ID: References: <171823002031.28307.18221225159709452537@vcs2.savannah.gnu.org> <20240612220700.A0F4DC1FB4C@vcs2.savannah.gnu.org> <86h6dwf40q.fsf@mail.linkov.net> <86frtffpdb.fsf@mail.linkov.net> <867ce6pwrq.fsf@mail.linkov.net> <86jzi5bnnz.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8694"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org, Dmitry Gutov To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jul 01 10:59:39 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sOCss-00022T-Dj for ged-emacs-devel@m.gmane-mx.org; Mon, 01 Jul 2024 10:59:38 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sOCs1-0005DN-PF; Mon, 01 Jul 2024 04:58:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sOCri-00050Q-I0 for emacs-devel@gnu.org; Mon, 01 Jul 2024 04:58:27 -0400 Original-Received: from mail.eshelyaron.com ([107.175.124.16] helo=eshelyaron.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sOCrf-0006jn-Ts for emacs-devel@gnu.org; Mon, 01 Jul 2024 04:58:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1719824302; bh=/9otOjum3ahI82yxICM2YVAOQlUQjgJbF/V1LRiY4Jc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Lf/kpmol49cqgFLGjNMXaawXlrlt05gdjTCbOuKhKx7doMnX2TBvybbmOXJ/NDYO6 d1jUFvUFLqqTbf0psjNL4m0Hs6xPOXDNgOLw3lTcfrsRj50Ejb905cB93B/qjr8Nh+ aC4Lg7q5enTVwYy1egLqLn3qFc8Tfvd3fq9V6Usd7E0vRqDrITm9svTmG94oow63X1 7sMZumHwJgaFaXSquZLKbV95NUtqsSdScxMsNP+GQwCKSGEHPNni2IjmWLraDogY2/ 4X95yT30MTeW9yG9iCiFDaHRmi2yAzF0shfPxmVH8TBVFVfduboY5lJaf6EQC3sMLJ uqYJtwivF4Thg== In-Reply-To: <86jzi5bnnz.fsf@mail.linkov.net> (Juri Linkov's message of "Mon, 01 Jul 2024 09:57:08 +0300") Received-SPF: pass client-ip=107.175.124.16; envelope-from=me@eshelyaron.com; helo=eshelyaron.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:321001 Archived-At: Juri Linkov writes: >>> 1. M-x icomplete-mode RET >>> 2. M-x rgrep RET foo RET b >>> >>> Error in post-command-hook (icomplete-post-command-hook): >>> (wrong-type-argument number-or-marker-p nil) >> >> Ouch. AFAICT the problem is in grep.el, and it's not specific to >> icomplete-mode, e.g. I can reproduce it with: >> >> M-: (grep-read-files "foo") RET b ? > > Also typing 'el TAB' after RET gives: > > Debugger entered--Lisp error: (error "Internal error: all doesn=E2=80=99t= match \\`el") > signal(error ("Internal error: all doesn=E2=80=99t match \\`el")) > error("Internal error: %s doesn't match %s" "all" "\\`el") > completion-pcm--merge-completions(("all" "el" "ch" "c" "cc" "cchh" "hh"= "h" "l" "am" "m" "tex" "texi" "asm") ("el")) > completion-pcm--merge-try(("el") ("all" "el" "ch" "c" "cc" "cchh" "hh" = "h" "l" "am" "m" "tex" "texi" "asm") "" "") > >> Does the diff below help? > > Thanks, after short testing I see it doesn't lose the ability to complete > in both cases: a list of abbreviations and file names, while fixing > the problem above, so it looks like the right thing to do. Great. >> (Note that this change has the downside that file name quoting/unquoting >> is no longer applied. Handling that with completion-table-merge might >> be a bit more tricky.) > > Not sure how serious this limitation is. Yes, it's very minor, I think. This issue is present already in Emacs 29 with partial-completion at the front of completion-styles, but in Emacs 30 it affects the default setup. Should we fix this on master or on the release branch?