unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Blocking call to accept-process-output with quit inhibited!!
@ 2013-06-21  5:47 Leo Liu
  2013-06-21  6:59 ` Leo Liu
  2013-06-21 14:54 ` Stefan Monnier
  0 siblings, 2 replies; 4+ messages in thread
From: Leo Liu @ 2013-06-21  5:47 UTC (permalink / raw)
  To: emacs-devel

After this change

* comint.el (comint-redirect-results-list-from-process): Fix random
  delay.

I am seeing "Blocking call to accept-process-output with quit
inhibited!!" from time to time.

How does this mean? I can't see where comint has inhibited quit.

Leo




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Blocking call to accept-process-output with quit inhibited!!
  2013-06-21  5:47 Blocking call to accept-process-output with quit inhibited!! Leo Liu
@ 2013-06-21  6:59 ` Leo Liu
  2013-06-21 14:54 ` Stefan Monnier
  1 sibling, 0 replies; 4+ messages in thread
From: Leo Liu @ 2013-06-21  6:59 UTC (permalink / raw)
  To: emacs-devel

Might be my fault. Feel free to ignore this.

Leo



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Blocking call to accept-process-output with quit inhibited!!
  2013-06-21  5:47 Blocking call to accept-process-output with quit inhibited!! Leo Liu
  2013-06-21  6:59 ` Leo Liu
@ 2013-06-21 14:54 ` Stefan Monnier
  2013-06-22  1:20   ` Leo Liu
  1 sibling, 1 reply; 4+ messages in thread
From: Stefan Monnier @ 2013-06-21 14:54 UTC (permalink / raw)
  To: Leo Liu; +Cc: emacs-devel

> * comint.el (comint-redirect-results-list-from-process): Fix random
>   delay.
> I am seeing "Blocking call to accept-process-output with quit
> inhibited!!" from time to time.
> How does this mean?

Just what it says: a call to accept-process-output was done at a time
when quit is inhibited, and the call can block, thus rendering Emacs
completely unresponsive.

> I can't see where comint has inhibited quit.

quit is inhibited when running timers, process-filters and other
such asynchronous events.
So comint doesn't need to inhibit-quit itself for such a warning to show
up, if its code is executed from a process-filter.

Try to figure out how/when a process-filter (or timer...) can end up
running the while + accept-process-output loop, and then think about
whether that really should happen, and if so make sure the
process-filter (or timer...) uses with-local-quit before running
that loop.


        Stefan



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Blocking call to accept-process-output with quit inhibited!!
  2013-06-21 14:54 ` Stefan Monnier
@ 2013-06-22  1:20   ` Leo Liu
  0 siblings, 0 replies; 4+ messages in thread
From: Leo Liu @ 2013-06-22  1:20 UTC (permalink / raw)
  To: emacs-devel

On 2013-06-21 22:54 +0800, Stefan Monnier wrote:
> Try to figure out how/when a process-filter (or timer...) can end up
> running the while + accept-process-output loop, and then think about
> whether that really should happen, and if so make sure the
> process-filter (or timer...) uses with-local-quit before running
> that loop.

Thanks, this helps.

Leo




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2013-06-22  1:20 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-21  5:47 Blocking call to accept-process-output with quit inhibited!! Leo Liu
2013-06-21  6:59 ` Leo Liu
2013-06-21 14:54 ` Stefan Monnier
2013-06-22  1:20   ` Leo Liu

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).