From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: mardani29@yahoo.es (Daniel =?utf-8?Q?Mart=C3=ADn?=) Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Add support for parsing column numbers in Visual Studio messages Date: Sun, 26 Jul 2020 22:57:01 +0200 Message-ID: References: <0D8E28C4-DB62-4499-8364-4EEA91D8DB29@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28628"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (darwin) Cc: emacs-devel@gnu.org To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jul 26 22:57:48 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jzniO-0007KA-2e for ged-emacs-devel@m.gmane-mx.org; Sun, 26 Jul 2020 22:57:48 +0200 Original-Received: from localhost ([::1]:49298 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jzniM-00068W-5K for ged-emacs-devel@m.gmane-mx.org; Sun, 26 Jul 2020 16:57:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55666) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jznhp-0005i6-JE for emacs-devel@gnu.org; Sun, 26 Jul 2020 16:57:13 -0400 Original-Received: from sonic310-11.consmr.mail.ir2.yahoo.com ([77.238.177.32]:45832) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jznhn-0000ab-8k for emacs-devel@gnu.org; Sun, 26 Jul 2020 16:57:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.es; s=s2048; t=1595797027; bh=YCA+UZQC73lNTc4PLlIbTh7asx6y+/AE0EQ/t1DehYU=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject; b=IbLM1H+2JsxpyThDp9HAkC8aM6sDuehCl3vJtahyufc0k5ThKJpTODb1P/R65FTB6ibafOWXfAwEah+N2XiPv1mys0vm/6jQWYJRIDQzjTEBYEwfdidN3hB5lXSsiE1BjBuED62s4WChn2z14XccFzyJK83cxdIfbmZeRNR+cy2WI0ykpFrSOdmqIktKm5DGyVQLAh7dYbQRxcDfwpDQ4RdGpI156Jeyj5s4alJtsiMY7aX83UHeLAbLhA9+Motio86d5Sq1gv5766oeiqkbKsu3ydAerE4tg8j0xXwFaxKP9i484jF8YzlbJXeHI+snrWP4QVXzSjjlj1RBhsYD5A== X-YMail-OSG: 0315nxUVM1kdEX6i.8r9jGH_YluH3kVihaPrEUGAScBsAtu_WtPdReCXxUyERpS idI_GYZdzIe5C0f5_34vlL3RihOpC34qTRfYUptfMpDccMiEV.MtPVFKz8jFtnOv7L3J.gN0vVg3 D_Kau7cowiGwFwuM1fi5uOBxD34sihgS.oYB9K2VQ4bDX1FMTwF0mHVh.wxHJUSQQ35WHSZB2coy jOf.ln.skVsAVTpbgPQepQ3A6uRCG7Ws6vV4L6Y3jRCZ2pswvR00KpKPT1C6szCuhMKTM7N0OJ7n O_g0N0zQnR8c_jHrnonpKjG1EQh2KBRZePoH7HrkCdWfKhPAGFsZmlfTDYkDUZ_R3PQbASfAkAds RvmUu1ETUd0.tfZC1tvz32doiM7L4OK7J6QDVsT5tG4OYqD8TallWWp4j01Ub84NYzsrgxwOzXD2 JPdGAN.Ef25y2iLWv.wMgXr6tdDQiL970qeyagZ8RRWYY3bsjqrew0T8dOjL.al_4zvo1bHu6Kxx VTMRSP.2RhNBVOsP67Y6r0PQBEMiYnPq8_VOISoi6ZCZ7y3CWdbhDmzkIAEEKHSvPuRkNLKBz.l9 xumiZiSFtyQJzINny.it2cWHeLlRT6fxzSsx8e1_AwJFgv.ul.TNs2necn5iChpQn.tbFb7EVICd isprhhTMvYZoHcxUeXdHEadMy2MInOaco3GTfUygzWe7Bya6pZ4vGz1XXb9Ioxl_stZpSVwgtgkW bprAuS3fLdPDwoVYWdQiHXRlGE8WfazMx1bLqJOend8BxGGg9M_9rRW2w541n9dgN_QsHVN0Y5QY rSSlOlZH6GsjrkOU7kW8Ow3WuIcs2uzh1Rl9ugg05. Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic310.consmr.mail.ir2.yahoo.com with HTTP; Sun, 26 Jul 2020 20:57:07 +0000 Original-Received: by smtp427.mail.ir2.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 66a1dd1b32a8b636ba7d6aed7e6bb1f1; Sun, 26 Jul 2020 20:57:02 +0000 (UTC) In-Reply-To: <0D8E28C4-DB62-4499-8364-4EEA91D8DB29@acm.org> ("Mattias \=\?utf-8\?Q\?Engdeg\=C3\=A5rd\=22's\?\= message of "Sun, 26 Jul 2020 17:52:32 +0200") X-Mailer: WebService/1.1.16271 hermes_yahoo Apache-HttpAsyncClient/4.1.4 (Java/11.0.7) Received-SPF: pass client-ip=77.238.177.32; envelope-from=mardani29@yahoo.es; helo=sonic310-11.consmr.mail.ir2.yahoo.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/26 16:57:08 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:253274 Archived-At: Mattias Engdeg=C3=A5rd writes: > 26 juli 2020 kl. 17.22 skrev Daniel Mart=C3=ADn : > >> The problem seems to happen because the regular expression for MSVC in c= ompile.el doesn't take into account column numbers. Attached is a proposed = patch to implement support for it. > > Thank you! This looks all right. Can you confirm that the column numberin= g works like in GCC -- ie, the leftmost column is 1, not 0? Yes, it works like in GCC, so I don't think it needs further adjustment. BTW, could you send me the FSF copyright assignment form? I may contribute some substantial work to Emacs in the future. Thanks. -- Daniel Mart=C3=ADn