From: mardani29@yahoo.es (Daniel Martín)
To: "Mattias Engdegård" <mattiase@acm.org>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] Add support for parsing column numbers in Visual Studio messages
Date: Sun, 26 Jul 2020 22:57:01 +0200 [thread overview]
Message-ID: <m11rkym1uq.fsf@yahoo.es> (raw)
In-Reply-To: <0D8E28C4-DB62-4499-8364-4EEA91D8DB29@acm.org> ("Mattias \=\?utf-8\?Q\?Engdeg\=C3\=A5rd\=22's\?\= message of "Sun, 26 Jul 2020 17:52:32 +0200")
Mattias Engdegård <mattiase@acm.org> writes:
> 26 juli 2020 kl. 17.22 skrev Daniel Martín <mardani29@yahoo.es>:
>
>> The problem seems to happen because the regular expression for MSVC in compile.el doesn't take into account column numbers. Attached is a proposed patch to implement support for it.
>
> Thank you! This looks all right. Can you confirm that the column numbering works like in GCC -- ie, the leftmost column is 1, not 0?
Yes, it works like in GCC, so I don't think it needs further adjustment.
BTW, could you send me the FSF copyright assignment form? I may
contribute some substantial work to Emacs in the future. Thanks.
--
Daniel Martín
next prev parent reply other threads:[~2020-07-26 20:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <b6edc68b-11b1-3567-d908-875d8134cfc3.ref@yahoo.es>
2020-07-26 15:22 ` [PATCH] Add support for parsing column numbers in Visual Studio messages Daniel Martín
2020-07-26 15:52 ` Mattias Engdegård
2020-07-26 20:57 ` Daniel Martín [this message]
2020-07-26 21:07 ` Stefan Monnier
2020-08-28 18:14 ` Daniel Martín
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m11rkym1uq.fsf@yahoo.es \
--to=mardani29@yahoo.es \
--cc=emacs-devel@gnu.org \
--cc=mattiase@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).