unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Bob Weiner <rsw@gnu.org>
To: emacs-devel@gnu.org
Subject: Problem quitting properly from transient keymap with one keystroke
Date: Wed, 18 Oct 2017 23:13:41 -0400	[thread overview]
Message-ID: <m0wp3r7rtm.rsw@gnu.org> (raw)

I am using set-transient-map to create an overriding keymap that
provides quick access to frame and window functions.  I have both a
stay-in-transient-map function and an on-exit function defined that
are sent as parameters to the set-transient-map call.

Everything is working as desired except for disabling the transient map.
Both C-g and q should disable the transient map and run the on-exit
function I have defined.  I am using inhibit-quit set to t to
control the operation of C-g.  Both C-g and q set a flag which informs
the stay-in-transient-map function to disable the keymap.  The on-exit
function then is called after the keymap is disabled and for C-g,
(keyboard-quit) is called.

The problem is that set-transient-map uses pre-command-hook to test the
stay-in-transient-map function and to exit, so if a keystroke sets the
flag read by the stay-in-transient-map function to disable the transient
map, this check is not done until another key is pressed because the
pre-command-hook is not run again until then (so the code doesn't see
the flag change until then).

I can't just add a post-command-hook that calls the transient map
disable function because calling (keyboard-quit) from the
post-command-hook triggers an error and I imagine that is not a proper
usage scenario.

Is there any clean way to exit and abort from a transient keymap upon a
single key press?  I have tried manually invoking (from the
post-command-hook) the disable function that set-transient-keymap
returns, but have not gotten that to work either.

FYI, when I mention a key, I mean a bound key within the current keymaps.


Thanks,

Bob



             reply	other threads:[~2017-10-19  3:13 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-19  3:13 Bob Weiner [this message]
2017-10-19 15:40 ` Problem quitting properly from transient keymap with one keystroke Robert Weiner
2017-10-20 12:24 ` Stefan Monnier
2017-10-20 12:27 ` Stefan Monnier
2017-10-20 14:45   ` Robert Weiner
2017-10-20 15:13     ` Stefan Monnier
2017-10-20 16:04       ` Robert Weiner
2017-10-20 17:34         ` Stefan Monnier
2017-10-20 17:51           ` Robert Weiner
2017-10-20 12:42 ` Oleh Krehel
2017-10-20 14:32   ` Robert Weiner
2017-10-20 14:36   ` Robert Weiner
2017-10-20 14:44   ` Stefan Monnier
2017-10-20 15:26     ` Oleh Krehel
2017-10-20 17:30       ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m0wp3r7rtm.rsw@gnu.org \
    --to=rsw@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).