* Re: [Emacs-diffs] master 16748a5 1/2: Add colors to faces that lack them.
@ 2017-11-03 20:22 Eli Zaretskii
2017-11-07 14:50 ` Sam Steingold
0 siblings, 1 reply; 3+ messages in thread
From: Eli Zaretskii @ 2017-11-03 20:22 UTC (permalink / raw)
To: Sam Steingold; +Cc: emacs-devel
I'd suggest to discuss any changes to face defaults before they are
committed. People tend to be sensitive to that, and the current
defaults are generally a result of more or less prolonged discussions.
Besides, faces can easily be customized, so the fact that you don't
like the default can be easily fixed on your systems, without
affecting everyone else.
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Emacs-diffs] master 16748a5 1/2: Add colors to faces that lack them.
2017-11-03 20:22 [Emacs-diffs] master 16748a5 1/2: Add colors to faces that lack them Eli Zaretskii
@ 2017-11-07 14:50 ` Sam Steingold
2017-11-07 16:13 ` Eli Zaretskii
0 siblings, 1 reply; 3+ messages in thread
From: Sam Steingold @ 2017-11-07 14:50 UTC (permalink / raw)
To: emacs-devel
> * Eli Zaretskii <ryvm@tah.bet> [2017-11-03 22:22:19 +0200]:
>
> I'd suggest to discuss any changes to face defaults before they are
> committed. People tend to be sensitive to that, and the current
> defaults are generally a result of more or less prolonged discussions.
> Besides, faces can easily be customized, so the fact that you don't
> like the default can be easily fixed on your systems, without
> affecting everyone else.
My apologies if the change inconveniences someone.
My excuse is that the default values for those faces were trivial.
(IOW, those faces were displayed identically to the default face).
I thought that it was a simple oversight, similar to not using
inheritance (fixed in a previous patch - separately specifically to make
the face change subject to a possible discussion or modification).
I would never think of changing a non-trivial user-visible default
without a discussion beforehand.
Thanks.
--
Sam Steingold (http://sds.podval.org/) on darwin Ns 10.3.1504
http://steingoldpsychology.com http://www.childpsy.net http://www.dhimmitude.org
http://www.memritv.org http://jij.org http://islamexposedonline.com
Illiterate? Write today, for free help!
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Emacs-diffs] master 16748a5 1/2: Add colors to faces that lack them.
2017-11-07 14:50 ` Sam Steingold
@ 2017-11-07 16:13 ` Eli Zaretskii
0 siblings, 0 replies; 3+ messages in thread
From: Eli Zaretskii @ 2017-11-07 16:13 UTC (permalink / raw)
To: sds; +Cc: emacs-devel
> From: Sam Steingold <sds@gnu.org>
> Date: Tue, 07 Nov 2017 09:50:44 -0500
>
> My excuse is that the default values for those faces were trivial.
> (IOW, those faces were displayed identically to the default face).
> I thought that it was a simple oversight
It likely wasn't, IME. But I don't really know, and I don't use Gnus,
so I will now shut up and let Gnus users speak up.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-07 16:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-03 20:22 [Emacs-diffs] master 16748a5 1/2: Add colors to faces that lack them Eli Zaretskii
2017-11-07 14:50 ` Sam Steingold
2017-11-07 16:13 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).