unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Sam Steingold <sds@gnu.org>
To: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 16748a5 1/2: Add colors to faces that lack them.
Date: Tue, 07 Nov 2017 09:50:44 -0500	[thread overview]
Message-ID: <lzzi7ycfcr.fsf@gnu.org> (raw)
In-Reply-To: 83bmkjun7o.fsf@gnu.org

> * Eli Zaretskii <ryvm@tah.bet> [2017-11-03 22:22:19 +0200]:
>
> I'd suggest to discuss any changes to face defaults before they are
> committed.  People tend to be sensitive to that, and the current
> defaults are generally a result of more or less prolonged discussions.
> Besides, faces can easily be customized, so the fact that you don't
> like the default can be easily fixed on your systems, without
> affecting everyone else.

My apologies if the change inconveniences someone.
My excuse is that the default values for those faces were trivial.
(IOW, those faces were displayed identically to the default face).
I thought that it was a simple oversight, similar to not using
inheritance (fixed in a previous patch - separately specifically to make
the face change subject to a possible discussion or modification).
I would never think of changing a non-trivial user-visible default
without a discussion beforehand.

Thanks.

-- 
Sam Steingold (http://sds.podval.org/) on darwin Ns 10.3.1504
http://steingoldpsychology.com http://www.childpsy.net http://www.dhimmitude.org
http://www.memritv.org http://jij.org http://islamexposedonline.com
Illiterate?  Write today, for free help!




  reply	other threads:[~2017-11-07 14:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-03 20:22 [Emacs-diffs] master 16748a5 1/2: Add colors to faces that lack them Eli Zaretskii
2017-11-07 14:50 ` Sam Steingold [this message]
2017-11-07 16:13   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=lzzi7ycfcr.fsf@gnu.org \
    --to=sds@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).