* Re: master f79c33b 3/3: Use special-mode for read-only buffers.
[not found] ` <20171122211510.0635E20445@vcs0.savannah.gnu.org>
@ 2017-11-24 18:29 ` Glenn Morris
2017-11-24 19:26 ` Sam Steingold
0 siblings, 1 reply; 2+ messages in thread
From: Glenn Morris @ 2017-11-24 18:29 UTC (permalink / raw)
To: emacs-devel; +Cc: Sam Steingold
Sam Steingold wrote:
> branch: master
> commit f79c33b39f195d1b30d7a3e085804e45ab76358e
> Use special-mode for read-only buffers.
>
> * lisp/progmodes/etags.el (tags-table-mode): Define using
> `define-derived-mode', inheriting from `special-mode'.
> Not only the buffer is now read-only, but you can bury it with "q".
> (select-tags-table-mode): No need to set `buffer-read-only'
> explicitly, `special-mode' takes care of that.
This change causes a test failure.
Ref: https://hydra.nixos.org/build/64565487
(user-error ("File /build/emacs-27.0.50/test/manual/etags/ETAGS.good_1 is not a valid tags table"))
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: master f79c33b 3/3: Use special-mode for read-only buffers.
2017-11-24 18:29 ` master f79c33b 3/3: Use special-mode for read-only buffers Glenn Morris
@ 2017-11-24 19:26 ` Sam Steingold
0 siblings, 0 replies; 2+ messages in thread
From: Sam Steingold @ 2017-11-24 19:26 UTC (permalink / raw)
To: emacs-devel
> * Glenn Morris <etz@tah.bet> [2017-11-24 13:29:39 -0500]:
>
> Sam Steingold wrote:
>
>> branch: master
>> commit f79c33b39f195d1b30d7a3e085804e45ab76358e
>
>> Use special-mode for read-only buffers.
>>
>> * lisp/progmodes/etags.el (tags-table-mode): Define using
>> `define-derived-mode', inheriting from `special-mode'.
>> Not only the buffer is now read-only, but you can bury it with "q".
>> (select-tags-table-mode): No need to set `buffer-read-only'
>> explicitly, `special-mode' takes care of that.
>
> This change causes a test failure.
> Ref: https://hydra.nixos.org/build/64565487
>
> (user-error ("File /build/emacs-27.0.50/test/manual/etags/ETAGS.good_1
> is not a valid tags table"))
Oops.
I think I know the reason for the failure and I just pushed a fix.
Thanks!
--
Sam Steingold (http://sds.podval.org/) on darwin Ns 10.3.1504
http://steingoldpsychology.com http://www.childpsy.net http://honestreporting.com
http://memri.org http://www.dhimmitude.org http://iris.org.il http://jij.org
Live Lisp and prosper.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-24 19:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20171122211508.603.67331@vcs0.savannah.gnu.org>
[not found] ` <20171122211510.0635E20445@vcs0.savannah.gnu.org>
2017-11-24 18:29 ` master f79c33b 3/3: Use special-mode for read-only buffers Glenn Morris
2017-11-24 19:26 ` Sam Steingold
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).