From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Sam Steingold Newsgroups: gmane.emacs.devel Subject: Re: Refactoring flymake.el Date: Fri, 18 Aug 2017 13:59:26 -0400 Organization: disorganization Message-ID: References: <87378q2r62.fsf@lolita> <6b4255cf-76c8-c6f3-15e4-b8fc97d4d2d2@yandex.ru> Reply-To: sds@gnu.org NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1503079205 14797 195.159.176.226 (18 Aug 2017 18:00:05 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 18 Aug 2017 18:00:05 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (darwin) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Aug 18 19:59:57 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dilYn-000388-09 for ged-emacs-devel@m.gmane.org; Fri, 18 Aug 2017 19:59:53 +0200 Original-Received: from localhost ([::1]:46024 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dilYr-0005Wd-UL for ged-emacs-devel@m.gmane.org; Fri, 18 Aug 2017 13:59:57 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52126) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dilYj-0005V3-KH for emacs-devel@gnu.org; Fri, 18 Aug 2017 13:59:51 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dilYg-0006E6-29 for emacs-devel@gnu.org; Fri, 18 Aug 2017 13:59:49 -0400 Original-Received: from [195.159.176.226] (port=39045 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dilYf-0006DU-RZ for emacs-devel@gnu.org; Fri, 18 Aug 2017 13:59:45 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1dilYV-0002Iv-Qy for emacs-devel@gnu.org; Fri, 18 Aug 2017 19:59:35 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 28 Original-X-Complaints-To: usenet@blaine.gmane.org X-Attribution: Sam X-Disclaimer: You should not expect anyone to agree with me. Cancel-Lock: sha1:fAEbPIeIr/1q6/bfBC8i2mmxSMk= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:217616 Archived-At: > * Dmitry Gutov [2017-08-18 19:25:16 +0300]: > >>> Only if such variable is not safe. If it's a boolean, for instance, >>> adding ":safe 'booleanp" to its defcustom should be easy. >> >> Of course. However, this variable is defined by a local >> `define-minor-mode', not `defcustom'. > > You can also mark it safe using `put' later. Like: > > (put 'abbrev-mode 'safe-local-variable 'booleanp) Yes, but this _is_ a security issue. flymake-mode actually _may_ run an OS command. I think it would be safe to _disable_ the mode, e.g., (put 'flymake-mode 'safe-local-variable 'null) Objections? PS. Do people really hate the `flymake-disallowed-file-name-regexp' patch? Why? -- Sam Steingold (http://sds.podval.org/) on darwin Ns 10.3.1504 http://steingoldpsychology.com http://www.childpsy.net http://think-israel.org http://americancensorship.org https://jihadwatch.org Please express your antipathy in the suicidal form.