unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Steingold <sds@gnu.org>
To: emacs-devel@gnu.org
Subject: Re: `unreadablep'
Date: Wed, 15 Dec 2021 11:09:58 -0500	[thread overview]
Message-ID: <lzfsqtkfxl.fsf@3c22fb11fdab.ant.amazon.com> (raw)
In-Reply-To: 87bl1imhnd.fsf@gnus.org

> * Lars Ingebrigtsen <ynefv@tahf.bet> [2021-12-15 08:49:58 +0100]:
>
> Do we have any primitive that can be used to check whether an object is
> printable or not?  Code like this (from savehist.el) makes me believe
> "not":
>
> 		;; Print elements of VALUE one by one, carefully.
> 		(dolist (elt value)
> 		  (let ((start (point)))
> 		    (insert " ")
> 		    ;; Try to print and then to read an element.
> 		    (condition-case nil
> 			(progn
> 			  (prin1 elt (current-buffer))
> 			  (save-excursion
> 			    (goto-char start)
> 			    (read (current-buffer))))
> 		      (error
> 		       ;; If writing or reading gave an error, comment it out.
> 		       (goto-char start)
> 		       (insert "\n")
> 		       (while (not (eobp))
> 			 (insert ";;; ")
> 			 (forward-line 1))
> 		       (insert "\n")))
> 		    (goto-char (point-max))))

I think the above code would have been perfect, if

1. prin1 were replaced with something like `(write ... :readably t)`
   (http://clhs.lisp.se/Body/f_wr_pr.htm), _and_

2. there were no `read` after `prin1`

(BTW, the return value of `read` is ignored, to be "honest", it should
be compared to `elt` using `equal`)

> It would be nice to have such a function (i.e., that says whether it can
> be read back after printing it).  The problem is, of course, complex
> structures that require recursing (and then checking for loops), etc, so
> you basically have to implement it the way printing is done if you want
> it to be fast, I think?
>
> Does anybody have any thoughts on this issue?

Why would one want to know in advance if the object is printable readably?
Only to decide how to print it, right?
Then the optimal approach is to _try_ to print readably and then take an
alternative/remedial action on failure.
This will usually save a structure traversal.

Thus I would advocate for a `print-readably' variable that would emulate
the CL behavior <http://clhs.lisp.se/Body/v_pr_rda.htm>.

> I wonder whether this could be efficiently implemented by, say, having
> some kind of special value for PRINTCHARFUN for prin1, but I haven't
> looked at the code yet.

Yeah, we could create a "/dev/null"-type object and pass it to prin1.
However, this would still make the above approach better in most cases.

(My original reply was, apparently, sent just to Lars, and was incorrect)

-- 
Sam Steingold (http://sds.podval.org/) on darwin Ns 10.3.2022
http://childpsy.net http://calmchildstories.com http://steingoldpsychology.com
https://www.memritv.org https://www.dhimmitude.org http://think-israel.org
When you are arguing with an idiot, your opponent is doing the same.




  parent reply	other threads:[~2021-12-15 16:09 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-15  7:49 `unreadablep' Lars Ingebrigtsen
2021-12-15  8:19 ` `unreadablep' Po Lu
2021-12-15  8:35   ` `unreadablep' Lars Ingebrigtsen
2021-12-15  9:42     ` `unreadablep' Po Lu
2021-12-15 11:16       ` `unreadablep' Lars Ingebrigtsen
2021-12-15 11:25         ` `unreadablep' Po Lu
2021-12-15 12:19           ` `unreadablep' Lars Ingebrigtsen
2021-12-15 12:22             ` `unreadablep' Po Lu
2021-12-15 12:35               ` `unreadablep' Lars Ingebrigtsen
2021-12-15 12:42                 ` `unreadablep' Po Lu
2021-12-15 12:44                   ` `unreadablep' Lars Ingebrigtsen
2021-12-15 12:46                     ` `unreadablep' Po Lu
2021-12-15 12:51                       ` `unreadablep' Po Lu
2021-12-15 12:58                       ` `unreadablep' Lars Ingebrigtsen
2021-12-15 12:36               ` `unreadablep' Ihor Radchenko
2021-12-15 12:37                 ` `unreadablep' Po Lu
2021-12-15 17:00     ` [External] : `unreadablep' Drew Adams
2021-12-15  8:35 ` `unreadablep' Ihor Radchenko
2021-12-15  9:51   ` `unreadablep' Po Lu
2021-12-15 10:20     ` `unreadablep' Ihor Radchenko
2021-12-15 10:21       ` `unreadablep' Ihor Radchenko
2021-12-15 10:21       ` `unreadablep' Po Lu
2021-12-15 10:36         ` `unreadablep' Ihor Radchenko
2021-12-15 10:44           ` `unreadablep' Po Lu
2021-12-15 11:12             ` `unreadablep' Ihor Radchenko
2021-12-15 11:16               ` `unreadablep' Po Lu
2021-12-15 11:39                 ` `unreadablep' Ihor Radchenko
2021-12-15 14:12 ` `unreadablep' Stefan Monnier
2021-12-16  5:48   ` `unreadablep' Lars Ingebrigtsen
2021-12-16  8:03     ` `unreadablep' Eli Zaretskii
2021-12-17  7:18       ` `unreadablep' Lars Ingebrigtsen
2021-12-16 15:35     ` `unreadablep' Qiantan Hong
2021-12-17  7:19       ` `unreadablep' Lars Ingebrigtsen
2021-12-15 15:32 ` `unreadablep' Steingold
2021-12-15 16:04   ` `unreadablep' Qiantan Hong
2021-12-15 16:09 ` Steingold [this message]
2021-12-15 20:21 ` `unreadablep' Philipp Stephani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=lzfsqtkfxl.fsf@3c22fb11fdab.ant.amazon.com \
    --to=sds@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).