From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sam Steingold Newsgroups: gmane.emacs.devel Subject: Re: package-update-all from command line Date: Thu, 26 May 2022 11:13:35 -0400 Message-ID: References: <877d6bd2a2.fsf@gnu.org> Reply-To: sds@gnu.org Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8484"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (darwin) To: emacs-devel@gnu.org, Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu May 26 17:19:06 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nuFGQ-0001zN-VG for ged-emacs-devel@m.gmane-mx.org; Thu, 26 May 2022 17:19:02 +0200 Original-Received: from localhost ([::1]:45390 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nuFGP-0006sq-Jm for ged-emacs-devel@m.gmane-mx.org; Thu, 26 May 2022 11:19:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50090) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nuFBI-00020e-UL for emacs-devel@gnu.org; Thu, 26 May 2022 11:13:44 -0400 Original-Received: from mail-qt1-x82f.google.com ([2607:f8b0:4864:20::82f]:37536) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nuFBC-0002Np-RV; Thu, 26 May 2022 11:13:44 -0400 Original-Received: by mail-qt1-x82f.google.com with SMTP id y15so1906031qtx.4; Thu, 26 May 2022 08:13:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:subject:in-reply-to:references:user-agent :return-receipt-to:reply-to:mail-followup-to:date:message-id :mime-version; bh=GKSLX1qiEsdpNdTdEvP5V6adVZ20RHKDQrLNLGfzeCs=; b=Or8XyApR2U8wx4sO/6oTdorle5VqvGuwuxCAA0yquhsvU/56H4+DRRklFTBqFX2lZH naVoAxqqcYz6QPv4+7rrNwjZ4vKyXpO+HfpQLsAvuJuMH8rJxSC+r9c8WcEp4p/9kNRy w3en34/JYWBcqy8tRBo0P+WfVCHuvmlcES34p1M72Q2y36VfvG7knsJJoiG4al5LaVZL 1N3KjQDWHrJSUj5DNdakfxNYA+2gbEB3aEYbb4fO0LyFUxQwHdL5HMs3kEkJb5rOLUSL kL80bHoVzvtTNpCHZ3ryh0I350WQdvwyy5nYVQIDBkmWpQ7/8Q2CPitduxFLDlEl+qc2 Pvrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:subject:in-reply-to:references :user-agent:return-receipt-to:reply-to:mail-followup-to:date :message-id:mime-version; bh=GKSLX1qiEsdpNdTdEvP5V6adVZ20RHKDQrLNLGfzeCs=; b=LTVemf4KL84kFj+ZEDiZEr88glOdIDfeV1KlQARarCztjRyZaK7j3rxYfQaZd09ndu ZjhdoT1XoVv0UjVliY0oqu5mRf+Mw3rBXxykyRJB+pegPh+7neY+0FLF6gkxgl746M8n 7Mou2W0AKWsTYvzyxZ+qkha/CopMQQLHSuAn+vfBBKVcsIty/djaxsq4aOtnTWp/N4rA ttu8sF4GQ2QpEjRNkjmRwGL8M5EghZ3fZMA9iiLL/A0R4q3Ep66jAGf+oU5ryoG3drTc gc/AwUJwgVWzRq4zPNRhaJ9/kZlfOlZqfq/HwkhAbFi3UaEqxFXIayfYNjJrbGG1TRSb 9nvA== X-Gm-Message-State: AOAM530NjIsnmvLHt15eM/5rCeyR3E8ud1hBxndbmWx8H2igqC0FXukq R93lW5KTbrIMyvDYxP27PLqToiq3aA== X-Google-Smtp-Source: ABdhPJwk/VjIQnYN84+UqnLxSL79zds6jQvuadaICPXKhlRSeK6r1/Np0VweHhGHJr2lCQYm5HCaaw== X-Received: by 2002:ad4:4ee4:0:b0:462:1da2:d823 with SMTP id dv4-20020ad44ee4000000b004621da2d823mr22532914qvb.19.1653578016940; Thu, 26 May 2022 08:13:36 -0700 (PDT) Original-Received: from 3c22fb11fdab.ant.amazon.com (pool-108-30-23-113.nycmny.fios.verizon.net. [108.30.23.113]) by smtp.gmail.com with ESMTPSA id j198-20020a37a0cf000000b0069fcdbabdb4sm1352235qke.69.2022.05.26.08.13.35 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 26 May 2022 08:13:35 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Wed, 25 May 2022 12:13:30 -0400") X-Attribution: Sam X-Disclaimer: You should not expect anyone to agree with me. Mail-Followup-To: emacs-devel@gnu.org, Stefan Monnier Received-SPF: pass client-ip=2607:f8b0:4864:20::82f; envelope-from=sam.steingold@gmail.com; helo=mail-qt1-x82f.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:290277 Archived-At: > * Stefan Monnier [2022-05-25 12:13:30 -0400]: > >> At any rate, I think replacing `append' with `cl-union' (or equivalent) >> in the code above would be a good idea. > > Indeed a `delete-dups` would be in order. Okay, so may I push --8<---------------cut here---------------start------------->8--- diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el index 3a05005fb5..4d95e9437a 100644 --- a/lisp/emacs-lisp/package.el +++ b/lisp/emacs-lisp/package.el @@ -4294,8 +4294,9 @@ package-quickstart-refresh (insert ")\n"))) (pp `(defvar package-activated-list) (current-buffer)) (pp `(setq package-activated-list - (append ',(mapcar #'package-desc-name package--quickstart-pkgs) - package-activated-list)) + (delete-dups + (append ',(mapcar #'package-desc-name package--quickstart-pkgs) + package-activated-list))) (current-buffer)) (let ((info-dirs (butlast Info-directory-list))) (when info-dirs --8<---------------cut here---------------end--------------->8--- -- Sam Steingold (http://sds.podval.org/) on darwin Ns 10.3.2113 http://childpsy.net http://calmchildstories.com http://steingoldpsychology.com http://think-israel.org https://jij.org https://mideasttruth.com nobody's life, liberty or property are safe while the legislature is in session