From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sam Steingold Newsgroups: gmane.emacs.devel Subject: Re: master 18b680cfd1: Fix bug#52467 by adding a new custom variable 'display-comint-buffer-action' Date: Wed, 29 Dec 2021 12:29:52 -0500 Organization: disorganization Message-ID: References: <164073060906.21430.4993248796177370312@vcs2.savannah.gnu.org> <20211228223009.6D0BAC002EE@vcs2.savannah.gnu.org> <871r1v8nhf.fsf@gnus.org> Reply-To: sds@gnu.org Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31138"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (darwin) To: emacs-devel@gnu.org Cancel-Lock: sha1:+ycqBetJZr45t8tFedQckjWTcSU= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Dec 29 18:31:24 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n2cnM-0007rp-0j for ged-emacs-devel@m.gmane-mx.org; Wed, 29 Dec 2021 18:31:24 +0100 Original-Received: from localhost ([::1]:48880 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n2cnK-0001bU-Jz for ged-emacs-devel@m.gmane-mx.org; Wed, 29 Dec 2021 12:31:22 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:50008) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n2cm2-0000jy-4V for emacs-devel@gnu.org; Wed, 29 Dec 2021 12:30:02 -0500 Original-Received: from ciao.gmane.io ([116.202.254.214]:45112) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n2clz-0003eJ-Ji for emacs-devel@gnu.org; Wed, 29 Dec 2021 12:30:01 -0500 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1n2clx-00061j-Sj for emacs-devel@gnu.org; Wed, 29 Dec 2021 18:29:57 +0100 X-Injected-Via-Gmane: http://gmane.org/ X-Attribution: Sam X-Disclaimer: You should not expect anyone to agree with me. Received-SPF: pass client-ip=116.202.254.214; envelope-from=ged-emacs-devel@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 2 X-Spam_score: 0.2 X-Spam_bar: / X-Spam_report: (0.2 / 5.0 requ) HEADER_FROM_DIFFERENT_DOMAINS=0.25, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:283581 Archived-At: > * Lars Ingebrigtsen [2021-12-29 16:00:44 +0100]: > > Sam Steingold writes: > >> Fix bug#52467 by adding a new custom variable 'display-comint-buffer-action' >> >> * lisp/window.el (display-comint-buffer-action): New `defcustom`, >> defaults to 'display-buffer-same-window' for backward compatibility. > > Others have noted the technical problems with this patch, but as the > discussion in bug#52467 showed, Emacs already has capabilities for > customising the behaviour here (via the general display machinery), and > adding something cross-cutting but specific to the coming-derived modes > just seems odd to me, so I'd be in favour of reverting this patch. `display-comint-buffer-action' was my concession to the people who wanted comint buffers displayed in the same window. Personally, I would _love_ to kill it and use plain `pop-to-buffer' everywhere. -- Sam Steingold (http://sds.podval.org/) on darwin Ns 10.3.2022 http://childpsy.net http://calmchildstories.com http://steingoldpsychology.com https://ij.org/ https://honestreporting.com https://jihadwatch.org Do not tell me what to do and I will not tell you where to go.