From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Howard Melman Newsgroups: gmane.emacs.devel Subject: Re: master c3e989ca9d7: New minor mode find-function-mode replaces find-function-setup-keys Date: Sat, 05 Oct 2024 12:56:13 -0400 Message-ID: References: <172800172214.1813703.15067539931889719779@vcs3.savannah.gnu.org> <20241004002843.024A41867DE@vcs3.savannah.gnu.org> <87v7y8ywok.fsf@melete.silentflame.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39434"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) To: emacs-devel@gnu.org Cancel-Lock: sha1:47eZShlTKpO8ur+wctN1TKyMyNs= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Oct 05 19:08:26 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sx8GY-000A6M-3r for ged-emacs-devel@m.gmane-mx.org; Sat, 05 Oct 2024 19:08:26 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sx8Fd-0003oE-BO; Sat, 05 Oct 2024 13:07:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sx84w-0002GK-JF for emacs-devel@gnu.org; Sat, 05 Oct 2024 12:56:26 -0400 Original-Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sx84u-000356-Sj for emacs-devel@gnu.org; Sat, 05 Oct 2024 12:56:26 -0400 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1sx84q-0009BU-N2 for emacs-devel@gnu.org; Sat, 05 Oct 2024 18:56:20 +0200 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=ged-emacs-devel@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 3 X-Spam_score: 0.3 X-Spam_bar: / X-Spam_report: (0.3 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NML_ADSP_CUSTOM_MED=0.9, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Sat, 05 Oct 2024 13:07:28 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:324336 Archived-At: Sean Whitton writes: > One option is just to keep find-function-setup-keys as it > was. Another would be to make the minor mode add the keys > to the global map, and remove them from it when > deactivated. How about that? I never understood why these commands were not just bound like many other commands. They've been around for 25+ years and AFAIK nothing else is competing with the bindings. If you want to bind these (useful) commands, both find-function-setup-keys and a minor mode require the find-function library to be loaded from the user's init, slowing down startup. (I duplicate the code from find-function-setup-keys in my init to avoid this). If there are users that bind these keys to other commands their customizations would be unaffected by having these commands bound. Now that other-window-prefix and other-frame-prefix exist, even binding the base commands to C-x [FKVL] would help. Those that would prefer to type C-x 4 F instead of C-x 4 4 C-x F can bind it themselves (though I'd prefer if all of these were bound by default). -- Howard