* Wrong fix?
@ 2006-03-12 15:45 Richard Stallman
2006-03-12 22:52 ` Károly Lőrentey
0 siblings, 1 reply; 3+ messages in thread
From: Richard Stallman @ 2006-03-12 15:45 UTC (permalink / raw)
Cc: emacs-devel
+#if 0 /* x_get_arg removes the visibility parameter as a side effect,
+ but x_create_frame still needs it. */
/* Start up iconic or window? */
x_wm_set_window_state
(f, (EQ (x_get_arg (dpyinfo, parms, Qvisibility, 0, 0, RES_TYPE_SYMBOL),
Qicon)
? IconicState
: NormalState));
+#endif
That seems like the wrong fix to me. If the goal is simply
to prevent x_get_arg from clearing out the parameter,
then this goes too far--it also prevents the parameter from being used
for calling x_wm_set_window_state.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Wrong fix?
2006-03-12 15:45 Wrong fix? Richard Stallman
@ 2006-03-12 22:52 ` Károly Lőrentey
2006-03-13 12:55 ` Richard Stallman
0 siblings, 1 reply; 3+ messages in thread
From: Károly Lőrentey @ 2006-03-12 22:52 UTC (permalink / raw)
Cc: Karoly Lorentey, emacs-devel
[-- Attachment #1.1: Type: text/plain, Size: 1096 bytes --]
Richard Stallman <rms@gnu.org> writes:
> +#if 0 /* x_get_arg removes the visibility parameter as a side effect,
> + but x_create_frame still needs it. */
> /* Start up iconic or window? */
> x_wm_set_window_state
> (f, (EQ (x_get_arg (dpyinfo, parms, Qvisibility, 0, 0, RES_TYPE_SYMBOL),
> Qicon)
> ? IconicState
> : NormalState));
> +#endif
>
> That seems like the wrong fix to me. If the goal is simply
> to prevent x_get_arg from clearing out the parameter,
> then this goes too far--it also prevents the parameter from being used
> for calling x_wm_set_window_state.
I chose the easier path of disabling the call because `x_create_frame'
sets the WM hints later anyway, by calling `x_iconify_frame' or
`x_make_frame_visible'. I did not find any reason to call
`x_wm_set_window_state' twice, but if people know of such a reason, I
will implement a better fix.
(The patch was committed to get rid of the annoying flicker
while creating an invisible frame:)
(make-frame '((visibility . nil)))
--
Károly
[-- Attachment #1.2: Type: application/pgp-signature, Size: 190 bytes --]
[-- Attachment #2: Type: text/plain, Size: 142 bytes --]
_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Wrong fix?
2006-03-12 22:52 ` Károly Lőrentey
@ 2006-03-13 12:55 ` Richard Stallman
0 siblings, 0 replies; 3+ messages in thread
From: Richard Stallman @ 2006-03-13 12:55 UTC (permalink / raw)
Cc: karoly, emacs-devel
I chose the easier path of disabling the call because `x_create_frame'
sets the WM hints later anyway, by calling `x_iconify_frame' or
`x_make_frame_visible'.
I didn't realize that. Perhaps your fix is right.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-03-13 12:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-03-12 15:45 Wrong fix? Richard Stallman
2006-03-12 22:52 ` Károly Lőrentey
2006-03-13 12:55 ` Richard Stallman
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).